Update homebrew formula to use [email protected] #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `[email protected]` is now the default when the formula aliases `python` or `python3` are used: https://formulae.brew.sh/formula/[email protected] As such, many other formulae are already using `[email protected]`, so updating to it for this project reduces the chance users will end up having to have two different Python versions installed.
Owner
|
Thanks! |
Contributor
Author
|
CI is failing after merge - not sure why? CI unfortunately didn't run on the PR due to: |
Owner
|
Probably because some binaries actually linked to python3.10. |
Owner
|
Reverted in 0d8895f, looks like it still requires python3.10. |
Contributor
Author
|
Thank you - sorry for the breakage. Perhaps it would be worth adjusting the CI config, so the tests run on PRs in the future? |
Owner
Don't know how to do that, |
edmorley
added a commit
to edmorley/homebrew-macos-cross-toolchains
that referenced
this pull request
Sep 8, 2024
Since `[email protected]` is now the default when the formula aliases `python` or `python3` are used: https://formulae.brew.sh/formula/[email protected] As such, many other formulae are already using `[email protected]`, so updating to it for this project reduces the chance users will end up having to have two different Python versions installed. Given that now: 1. `crosstool-ng` has already updated it's own `depends_on` to `[email protected]` 2. The Python command alias here has been set to `python3` via `CT_GDB_CROSS_PYTHON_BINARY` in the various `.config`s ...I'm hopeful this should be more successful than when I attempted a Python version bump to 3.11 in messense#20 :-)
messense
pushed a commit
that referenced
this pull request
Sep 12, 2024
Since `[email protected]` is now the default when the formula aliases `python` or `python3` are used: https://formulae.brew.sh/formula/[email protected] As such, many other formulae are already using `[email protected]`, so updating to it for this project reduces the chance users will end up having to have two different Python versions installed. Given that now: 1. `crosstool-ng` has already updated it's own `depends_on` to `[email protected]` 2. The Python command alias here has been set to `python3` via `CT_GDB_CROSS_PYTHON_BINARY` in the various `.config`s ...I'm hopeful this should be more successful than when I attempted a Python version bump to 3.11 in #20 :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
[email protected]is now the default when the formula aliasespython,python3orpython@3are used:https://formulae.brew.sh/formula/[email protected]
As such, many other formulae are already depending upon
[email protected], so switching to it for this project reduces the chance users will end up needing to have two different Python versions installed.