cmake: Allow recasting a CMake dependency into an Apple framework#12181
Merged
jpakkane merged 1 commit intomesonbuild:masterfrom Feb 24, 2024
Merged
cmake: Allow recasting a CMake dependency into an Apple framework#12181jpakkane merged 1 commit intomesonbuild:masterfrom
jpakkane merged 1 commit intomesonbuild:masterfrom
Conversation
tristan957
reviewed
Aug 31, 2023
tristan957
reviewed
Aug 31, 2023
Member
|
@kiwixz another PR for review if you are interested. The test failures look relevant. |
amyspark
force-pushed
the
cmake-recast-frameworks
branch
2 times, most recently
from
fc1454c to
2a72a8e
Compare
Member
|
Any chance there could be a test added to this which failed before this commit and passed after? |
amyspark
force-pushed
the
cmake-recast-frameworks
branch
from
2a72a8e to
361b219
Compare
Contributor
Author
|
@tristan I've added the repro from the issue here. Let me know if there's anything else to address. |
jpakkane
reviewed
Feb 24, 2024
amyspark
force-pushed
the
cmake-recast-frameworks
branch
from
361b219 to
efa6e03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the combination of macOS + GCC to still find frameworks. This can already be done through CMake's own support of framework lookup (which is undocumented at the moment).
However, there's a catch: CMake's fileapi sometimes exposes these through raw framework directories, which are recast at generation time into
-F /path/to/framework/folder -framework name. This needs to be done manually, so I duplicated two bits of code inExtraFrameworkDependencyto achieve this.Fixes #12160