test cases: Don't fall off the end of main() without an exit status

smcv · dcbaker · commit f0e9a44d41e2 · 2022-06-30T09:55:48.000-07:00
This is undefined behaviour, and seems to have caused test failures
when backporting Meson to an older toolchain in the Steam Runtime.

Signed-off-by: Simon McVittie &lt;smcv@collabora.com&gt;
diff --git a/test cases/common/141 special characters/arg-char-test.c b/test cases/common/141 special characters/arg-char-test.c
@@ -7,4 +7,5 @@ int main(int argc, char **argv) {
   if (c != argv[1][0])
     fprintf(stderr, "Expected %x, got %x\n", (unsigned int) c, (unsigned int) argv[1][0]);
   assert(c == argv[1][0]);
+  return 0;
 }
diff --git a/test cases/common/141 special characters/arg-string-test.c b/test cases/common/141 special characters/arg-string-test.c
@@ -9,4 +9,5 @@ int main(int argc, char **argv) {
   if (s[0] != argv[1][0])
     fprintf(stderr, "Expected %x, got %x\n", (unsigned int) s[0], (unsigned int) argv[1][0]);
   assert(s[0] == argv[1][0]);
+  return 0;
 }
diff --git a/test cases/common/141 special characters/arg-unquoted-test.c b/test cases/common/141 special characters/arg-unquoted-test.c
@@ -14,4 +14,5 @@ int main(int argc, char **argv) {
   assert(s[0] == argv[1][0]);
   // There is no way to convert a macro argument into a character constant.
   // Otherwise we'd test that as well
+  return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -7,4 +7,5 @@ int main(int argc, char **argv) {`
`7`	`7`	`if (c != argv[1][0])`
`8`	`8`	`fprintf(stderr, "Expected %x, got %x\n", (unsigned int) c, (unsigned int) argv[1][0]);`
`9`	`9`	`assert(c == argv[1][0]);`
	`10`	`+ return 0;`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,5 @@ int main(int argc, char **argv) {`
`9`	`9`	`if (s[0] != argv[1][0])`
`10`	`10`	`fprintf(stderr, "Expected %x, got %x\n", (unsigned int) s[0], (unsigned int) argv[1][0]);`
`11`	`11`	`assert(s[0] == argv[1][0]);`
	`12`	`+ return 0;`
`12`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,4 +14,5 @@ int main(int argc, char **argv) {`
`14`	`14`	`assert(s[0] == argv[1][0]);`
`15`	`15`	`// There is no way to convert a macro argument into a character constant.`
`16`	`16`	`// Otherwise we'd test that as well`
	`17`	`+ return 0;`
`17`	`18`	`}`