Skip to content

Commit a92e2b1

Browse files
dcbakernirbheek
authored andcommitted
vala: don't build .h, .vala, and .gir if export_dynamic is False
The current check results in *any* value to `export_dynamic` generating vala import targets, even `false`. This is pretty clearly wrong, as it really wants to treat an unset export_dynamic as false.
1 parent 1b4bc96 commit a92e2b1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mesonbuild/build.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1073,7 +1073,7 @@ def process_kwargs(self, kwargs):
10731073
self.add_pch('c', extract_as_list(kwargs, 'c_pch'))
10741074
self.add_pch('cpp', extract_as_list(kwargs, 'cpp_pch'))
10751075

1076-
if not isinstance(self, Executable) or 'export_dynamic' in kwargs:
1076+
if not isinstance(self, Executable) or kwargs.get('export_dynamic', False):
10771077
self.vala_header = kwargs.get('vala_header', self.name + '.h')
10781078
self.vala_vapi = kwargs.get('vala_vapi', self.name + '.vapi')
10791079
self.vala_gir = kwargs.get('vala_gir', None)

0 commit comments

Comments
 (0)