Skip to content

Fix for hopLimit param on sendTraceRoute not being respected#629

Merged
ianmcorvidae merged 2 commits intomeshtastic:masterfrom
ppicazo:trace_route_hop_fix
Jul 8, 2024
Merged

Fix for hopLimit param on sendTraceRoute not being respected#629
ianmcorvidae merged 2 commits intomeshtastic:masterfrom
ppicazo:trace_route_hop_fix

Conversation

@ppicazo
Copy link
Contributor

@ppicazo ppicazo commented Jul 2, 2024

If you use:

interface.sendTraceRoute(dest="!3b46b95d", hopLimit=5)

The hopLimit param specified is not used for the trace route as expected, the lora config hopLimit is used. This fix allows trace routes to be sent with a dynamic hop limit as the sendTraceRoute method definition would lead you to believe is possible.

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ianmcorvidae
Copy link
Contributor

I think this looks good; might be something we can extend to more functions, but for now keeping it on sendData is probably sufficient. It looks like pylint is complaining about something, so we can get that fixed and get this in!

@ianmcorvidae ianmcorvidae merged commit 19d7e91 into meshtastic:master Jul 8, 2024
@ppicazo ppicazo deleted the trace_route_hop_fix branch July 8, 2024 03:52
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.61%. Comparing base (0e6a0eb) to head (64bb668).
⚠️ Report is 506 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/mesh_interface.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   61.90%   61.61%   -0.30%     
==========================================
  Files          14       14              
  Lines        3019     3040      +21     
==========================================
+ Hits         1869     1873       +4     
- Misses       1150     1167      +17     
Flag Coverage Δ
unittests 61.61% <83.33%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants