Fix for hopLimit param on sendTraceRoute not being respected#629
Fix for hopLimit param on sendTraceRoute not being respected#629ianmcorvidae merged 2 commits intomeshtastic:masterfrom
Conversation
|
|
|
I think this looks good; might be something we can extend to more functions, but for now keeping it on sendData is probably sufficient. It looks like pylint is complaining about something, so we can get that fixed and get this in! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 61.90% 61.61% -0.30%
==========================================
Files 14 14
Lines 3019 3040 +21
==========================================
+ Hits 1869 1873 +4
- Misses 1150 1167 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If you use:
The
hopLimitparam specified is not used for the trace route as expected, the lora confighopLimitis used. This fix allows trace routes to be sent with a dynamic hop limit as thesendTraceRoutemethod definition would lead you to believe is possible.