refactor(desktop): remove native MenuBar from main window#4888
Merged
jamesarich merged 1 commit intomainfrom Mar 23, 2026
Merged
refactor(desktop): remove native MenuBar from main window#4888jamesarich merged 1 commit intomainfrom
jamesarich merged 1 commit intomainfrom
Conversation
This commit removes the Compose Multiplatform `MenuBar` implementation from the desktop entry point. The application's navigation and settings access, previously handled via the native system menu, are being streamlined or relocated. Specific changes include: - Removed `MenuBar` and all its associated submenus (File, View, Navigate, Help) from `Main.kt`. - Removed unused imports related to keyboard shortcuts and window menu components. - Deleted the logic for manual navigation stack manipulation within the menu item callbacks. Signed-off-by: James Rich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the Compose Multiplatform
MenuBarimplementation from the desktop entry point. The application's navigation and settings access, previously handled via the native system menu, are being streamlined or relocated.Specific changes include:
MenuBarand all its associated submenus (File, View, Navigate, Help) fromMain.kt.