Skip to content

Add InlineMap implementation for F-Droid build#4877

Merged
jamesarich merged 2 commits intomeshtastic:mainfrom
theKorzh:feature/fdroid-inline-map
Mar 22, 2026
Merged

Add InlineMap implementation for F-Droid build#4877
jamesarich merged 2 commits intomeshtastic:mainfrom
theKorzh:feature/fdroid-inline-map

Conversation

@theKorzh
Copy link
Copy Markdown
Contributor

@theKorzh theKorzh commented Mar 22, 2026

This implements the InlineMap component for the F-Droid build, which was previously a no-op.

Changes:

  • Added osmdroid-based map rendering
  • Displays node position with a marker
  • Brings F-Droid behavior closer to the Google build by showing a map preview in node details

While osmdroid is currently unmaintained, it is already used in the app for the nodes map screen. Given that, this change avoids leaving an empty placeholder in the node details screen and provides a more consistent user experience across build variants.

Tested:

  • F-Droid build compiles successfully
  • Map renders correctly in node details
  • Marker displays as expected

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 22, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 22, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the enhancement New feature or request label Mar 22, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 22, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.66%. Comparing base (f04924d) to head (8ea5ca7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4877      +/-   ##
==========================================
+ Coverage   12.36%   14.66%   +2.30%     
==========================================
  Files         575      571       -4     
  Lines       19041    18917     -124     
  Branches     2777     2773       -4     
==========================================
+ Hits         2354     2775     +421     
+ Misses      16461    15814     -647     
- Partials      226      328     +102
Flag Coverage Δ
host-unit 14.66% <ø> (+2.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jamesarich
jamesarich approved these changes Mar 22, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamesarich jamesarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jamesarich jamesarich added this pull request to the merge queue Mar 22, 2026
Merged via the queue into meshtastic:main with commit ee146df Mar 22, 2026
8 checks passed
@theKorzh theKorzh deleted the feature/fdroid-inline-map branch March 22, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesarich jamesarich jamesarich approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@theKorzh @CLAassistant @jamesarich