meshtastic · jamesarich · Mar 19, 2026 · Mar 19, 2026 · Mar 19, 2026 · Mar 19, 2026
diff --git a/.github/workflows/reusable-check.yml b/.github/workflows/reusable-check.yml
@@ -256,3 +256,4 @@ jobs:
           path: |
             **/build/outputs/androidTest-results
           retention-days: 7
+          if-no-files-found: ignore
diff --git a/AGENTS.md b/AGENTS.md
@@ -77,7 +77,7 @@ Meshtastic-Android is a Kotlin Multiplatform (KMP) application for off-grid, dec
 -   **JetBrains fork aliases:** Version catalog aliases for JetBrains-forked AndroidX artifacts use the `jetbrains-*` prefix (e.g., `jetbrains-lifecycle-runtime-compose`, `jetbrains-navigation3-ui`). Plain `androidx-*` aliases are true Google AndroidX artifacts. Never mix them up in `commonMain`.
 -   **Compose Multiplatform:** Version catalog aliases for Compose Multiplatform artifacts use the `compose-multiplatform-*` prefix (e.g., `compose-multiplatform-material3`, `compose-multiplatform-foundation`). Never use plain `androidx.compose` dependencies in common Main.
 -   **Room KMP:** Always use `factory = { MeshtasticDatabaseConstructor.initialize() }` in `Room.databaseBuilder` and `inMemoryDatabaseBuilder`. DAOs and Entities reside in `commonMain`.
--   **Testing:** Write ViewModel and business logic tests in `commonTest`. Use `core:testing` shared fakes.
+-   **Testing:** Write ViewModel and business logic tests in `commonTest`. Use `Turbine` for Flow testing, `Kotest` for property-based testing, and `Mokkery` for mocking. Use `core:testing` shared fakes.
 -   **Build-logic conventions:** In `build-logic/convention`, prefer lazy Gradle configuration (`configureEach`, `withPlugin`, provider APIs). Avoid `afterEvaluate` in convention plugins unless there is no viable lazy alternative.
 
 ### C. Namespacing

diff --git a/GEMINI.md b/GEMINI.md
@@ -77,7 +77,7 @@ Meshtastic-Android is a Kotlin Multiplatform (KMP) application for off-grid, dec
 -   **JetBrains fork aliases:** Version catalog aliases for JetBrains-forked AndroidX artifacts use the `jetbrains-*` prefix (e.g., `jetbrains-lifecycle-runtime-compose`, `jetbrains-navigation3-ui`). Plain `androidx-*` aliases are true Google AndroidX artifacts. Never mix them up in `commonMain`.
 -   **Compose Multiplatform:** Version catalog aliases for Compose Multiplatform artifacts use the `compose-multiplatform-*` prefix (e.g., `compose-multiplatform-material3`, `compose-multiplatform-foundation`). Never use plain `androidx.compose` dependencies in common Main.
 -   **Room KMP:** Always use `factory = { MeshtasticDatabaseConstructor.initialize() }` in `Room.databaseBuilder` and `inMemoryDatabaseBuilder`. DAOs and Entities reside in `commonMain`.
--   **Testing:** Write ViewModel and business logic tests in `commonTest`. Use `core:testing` shared fakes.
+-   **Testing:** Write ViewModel and business logic tests in `commonTest`. Use `Turbine` for Flow testing, `Kotest` for property-based testing, and `Mokkery` for mocking. Use `core:testing` shared fakes.
 -   **Build-logic conventions:** In `build-logic/convention`, prefer lazy Gradle configuration (`configureEach`, `withPlugin`, provider APIs). Avoid `afterEvaluate` in convention plugins unless there is no viable lazy alternative.
 
 ### C. Namespacing

diff --git a/...r/tracks/expand_testing_20260318/index.md → .../archive/expand_testing_20260318/index.md b/...r/tracks/expand_testing_20260318/index.md → .../archive/expand_testing_20260318/index.md
diff --git a/...cks/expand_testing_20260318/metadata.json → ...ive/expand_testing_20260318/metadata.json b/...cks/expand_testing_20260318/metadata.json → ...ive/expand_testing_20260318/metadata.json
diff --git a/conductor/archive/expand_testing_20260318/plan.md b/conductor/archive/expand_testing_20260318/plan.md
@@ -0,0 +1,32 @@
+# Implementation Plan: Expand Testing Coverage
+
+## Phase 1: Baseline Measurement [checkpoint: 6d9ad46]
+- [x] Task: Execute `./gradlew koverLog` and record current project test coverage. 8bdd673a1
+- [x] Task: Conductor - User Manual Verification 'Phase 1: Baseline Measurement' (Protocol in workflow.md) 6d9ad468c
+
+## Phase 2: Feature ViewModel Migration to Turbine [checkpoint: 61b9595]
+- [x] Task: Refactor `MetricsViewModelTest` to use `Turbine` and `Mokkery` in `commonTest`. 79e059286
+- [x] Task: Refactor `MessageViewModelTest` to use `Turbine` and `Mokkery` in `commonTest`. b45697b53
+- [x] Task: Refactor `RadioConfigViewModelTest` to use `Turbine` and `Mokkery` in `commonTest`. 33e10fc6c
+- [x] Task: Refactor `NodeListViewModelTest` to use `Turbine` and `Mokkery` in `commonTest`. 33e10fc6c
+- [x] Task: Refactor remaining `feature` ViewModels to use `Turbine` and `Mokkery`. 33e10fc6c
+- [x] Task: Conductor - User Manual Verification 'Phase 2: Feature ViewModel Migration to Turbine' (Protocol in workflow.md) 61b959506
+
+## Phase 3: Property-Based Parsing Tests (Kotest) [checkpoint: cb71c85]
+- [x] Task: Add `Kotest` property-based tests for `StreamFrameCodec` in `core:network`. 2c8fd6a8f
+- [x] Task: Add `Kotest` property-based tests for `PacketHandler` implementations in `core:data`. 7d56c3fef
+- [x] Task: Add `Kotest` property-based tests for `TcpTransport` and/or `SerialTransport` in `core:network`. 2fd68d67e
+- [x] Task: Conductor - User Manual Verification 'Phase 3: Property-Based Parsing Tests (Kotest)' (Protocol in workflow.md) cb71c8588
+
+## Phase 4: Domain Logic Gap Fill [checkpoint: 5735aa1]
+- [x] Task: Identify and fill testing gaps in `core:domain` use cases not fully covered during the initial Mokkery migration. 7b815130f
+- [x] Task: Conductor - User Manual Verification 'Phase 4: Domain Logic Gap Fill' (Protocol in workflow.md) 5735aa148
+
+## Phase 5: Final Measurement & Verification [checkpoint: e321cf0]
+- [x] Task: Execute full test suite (`./gradlew test`) to ensure stability. 02fa96f37
+- [x] Task: Execute `./gradlew koverLog` to generate and document the final coverage metrics. e3fe4ba1e
+- [x] Task: Conductor - User Manual Verification 'Phase 5: Final Measurement & Verification' (Protocol in workflow.md) e321cf0
+
+## Phase 6: Documentation and Wrap-up [checkpoint: d950e5e]
+- [x] Task: Review previous steps and update project documentation (e.g., `README.md`, testing guides). b2c9d3e
+- [x] Task: Conductor - User Manual Verification 'Phase 6: Documentation and Wrap-up' (Protocol in workflow.md) d950e5e
diff --git a/...or/tracks/expand_testing_20260318/spec.md → ...r/archive/expand_testing_20260318/spec.md b/...or/tracks/expand_testing_20260318/spec.md → ...r/archive/expand_testing_20260318/spec.md
diff --git a/conductor/tech-stack.md b/conductor/tech-stack.md
@@ -33,4 +33,4 @@
 - **Coroutines Testing:** Use `kotlinx-coroutines-test` for virtual time management in asynchronous flows.
 - **Mocking Strategy:** Avoid JVM-specific mocking libraries. Prefer `Mokkery` or `Mockative` for multiplatform-compatible mocking interfaces, alongside handwritten fakes in `core:testing`.
 - **Flow Assertions:** Use `Turbine` for testing multiplatform `Flow` emissions and state updates.
-- **Property-Based Testing:** Consider evaluating `Kotest` for multiplatform data-driven and property-based testing scenarios if standard `kotlin.test` becomes insufficient.
+- **Property-Based Testing:** Use `Kotest` for multiplatform data-driven and property-based testing scenarios.
diff --git a/conductor/tracks.md b/conductor/tracks.md
@@ -2,7 +2,3 @@
 
 This file tracks all major tracks for the project. Each track has its own detailed plan in its respective folder.
 
----
-- [ ] **Track: Expand Testing Coverage**
-*Link: [./tracks/expand_testing_20260318/](./tracks/expand_testing_20260318/)*
-
diff --git a/conductor/tracks/expand_testing_20260318/plan.md b/conductor/tracks/expand_testing_20260318/plan.md
diff --git a/core/data/build.gradle.kts b/core/data/build.gradle.kts
@@ -71,6 +71,8 @@ kotlin {
         commonTest.dependencies {
             implementation(kotlin("test"))
             implementation(libs.kotlinx.coroutines.test)
+            implementation(libs.kotest.assertions)
+            implementation(libs.kotest.property)
         }
     }
 }
diff --git a/core/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/TracerouteHandlerImpl.kt b/core/data/src/commonMain/kotlin/org/meshtastic/core/data/manager/TracerouteHandlerImpl.kt
@@ -24,7 +24,6 @@ import org.koin.core.annotation.Single
 import org.meshtastic.core.common.util.NumberFormatter
 import org.meshtastic.core.common.util.handledLaunch
 import org.meshtastic.core.common.util.nowMillis
-import org.meshtastic.core.data.repository.TracerouteSnapshotRepository
 import org.meshtastic.core.model.Node
 import org.meshtastic.core.model.fullRouteDiscovery
 import org.meshtastic.core.model.getFullTracerouteResponse
@@ -34,6 +33,7 @@ import org.meshtastic.core.repository.NodeManager
 import org.meshtastic.core.repository.NodeRepository
 import org.meshtastic.core.repository.ServiceRepository
 import org.meshtastic.core.repository.TracerouteHandler
+import org.meshtastic.core.repository.TracerouteSnapshotRepository
 import org.meshtastic.proto.MeshPacket
 
 @Single

diff --git a/...epository/TracerouteSnapshotRepository.kt → ...itory/TracerouteSnapshotRepositoryImpl.kt b/...epository/TracerouteSnapshotRepository.kt → ...itory/TracerouteSnapshotRepositoryImpl.kt
@@ -27,22 +27,23 @@ import org.koin.core.annotation.Single
 import org.meshtastic.core.database.DatabaseProvider
 import org.meshtastic.core.database.entity.TracerouteNodePositionEntity
 import org.meshtastic.core.di.CoroutineDispatchers
+import org.meshtastic.core.repository.TracerouteSnapshotRepository
 import org.meshtastic.proto.Position
 
 @Single
-class TracerouteSnapshotRepository(
+class TracerouteSnapshotRepositoryImpl(
     private val dbManager: DatabaseProvider,
     private val dispatchers: CoroutineDispatchers,
-) {
+) : TracerouteSnapshotRepository {
 
-    fun getSnapshotPositions(logUuid: String): Flow<Map<Int, Position>> = dbManager.currentDb
+    override fun getSnapshotPositions(logUuid: String): Flow<Map<Int, Position>> = dbManager.currentDb
         .flatMapLatest { it.tracerouteNodePositionDao().getByLogUuid(logUuid) }
         .distinctUntilChanged()
         .mapLatest { list -> list.associate { it.nodeNum to it.position } }
         .flowOn(dispatchers.io)
         .conflate()
 
-    suspend fun upsertSnapshotPositions(logUuid: String, requestId: Int, positions: Map<Int, Position>) =
+    override suspend fun upsertSnapshotPositions(logUuid: String, requestId: Int, positions: Map<Int, Position>) =
         withContext(dispatchers.io) {
             val dao = dbManager.currentDb.value.tracerouteNodePositionDao()
             dao.deleteByLogUuid(logUuid)

diff --git a/core/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/PacketHandlerImplTest.kt b/core/data/src/commonTest/kotlin/org/meshtastic/core/data/manager/PacketHandlerImplTest.kt
@@ -22,6 +22,9 @@ import dev.mokkery.every
 import dev.mokkery.matcher.any
 import dev.mokkery.mock
 import dev.mokkery.verifySuspend
+import io.kotest.property.Arb
+import io.kotest.property.arbitrary.int
+import io.kotest.property.checkAll
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.test.StandardTestDispatcher
 import kotlinx.coroutines.test.TestScope
@@ -39,6 +42,7 @@ import org.meshtastic.proto.QueueStatus
 import org.meshtastic.proto.ToRadio
 import kotlin.test.BeforeTest
 import kotlin.test.Test
+import kotlin.test.assertNotNull
 
 class PacketHandlerImplTest {
 
@@ -70,13 +74,16 @@ class PacketHandlerImplTest {
         handler.start(testScope)
     }
 
+    @Test
+    fun testInitialization() {
+        assertNotNull(handler)
+    }
+
     @Test
     fun `sendToRadio with ToRadio sends immediately`() {
         val toRadio = ToRadio(packet = MeshPacket(id = 123))
 
         handler.sendToRadio(toRadio)
-
-        // No explicit assertion here in original test, but we could verify call
     }
 
     @Test
@@ -107,6 +114,17 @@ class PacketHandlerImplTest {
         testScheduler.runCurrent()
     }
 
+    @Test
+    fun `handleQueueStatus property test`() = runTest(testDispatcher) {
+        checkAll(Arb.int(0, 10), Arb.int(0, 32), Arb.int(0, 100000)) { res, free, packetId ->
+            val status = QueueStatus(res = res, free = free, mesh_packet_id = packetId)
+
+            // Ensure it doesn't crash on any input
+            handler.handleQueueStatus(status)
+            testScheduler.runCurrent()
+        }
+    }
+
     @Test
     fun `outgoing packets are logged with NODE_NUM_LOCAL`() = runTest(testDispatcher) {
         val packet = MeshPacket(id = 123, decoded = Data(portnum = PortNum.TEXT_MESSAGE_APP))

diff --git a/...src/commonTest/kotlin/org/meshtastic/core/domain/usecase/settings/SetLocaleUseCaseTest.kt b/...src/commonTest/kotlin/org/meshtastic/core/domain/usecase/settings/SetLocaleUseCaseTest.kt
@@ -0,0 +1,44 @@
+/*
+ * Copyright (c) 2026 Meshtastic LLC
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+package org.meshtastic.core.domain.usecase.settings
+
+import dev.mokkery.answering.returns
+import dev.mokkery.every
+import dev.mokkery.matcher.any
+import dev.mokkery.mock
+import dev.mokkery.verify
+import org.meshtastic.core.common.UiPreferences
+import kotlin.test.BeforeTest
+import kotlin.test.Test
+
+class SetLocaleUseCaseTest {
+
+    private val uiPreferences: UiPreferences = mock()
+    private lateinit var useCase: SetLocaleUseCase
+
+    @BeforeTest
+    fun setUp() {
+        useCase = SetLocaleUseCase(uiPreferences)
+    }
+
+    @Test
+    fun `invoke calls setLocale on uiPreferences`() {
+        every { uiPreferences.setLocale(any()) } returns Unit
+        useCase("en")
+        verify { uiPreferences.setLocale("en") }
+    }
+}
diff --git a/.../kotlin/org/meshtastic/core/domain/usecase/settings/SetNotificationSettingsUseCaseTest.kt b/.../kotlin/org/meshtastic/core/domain/usecase/settings/SetNotificationSettingsUseCaseTest.kt
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2026 Meshtastic LLC
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <https://www.gnu.org/licenses/>.
+ */
+package org.meshtastic.core.domain.usecase.settings
+
+import dev.mokkery.answering.returns
+import dev.mokkery.every
+import dev.mokkery.matcher.any
+import dev.mokkery.mock
+import dev.mokkery.verify
+import org.meshtastic.core.repository.NotificationPrefs
+import kotlin.test.BeforeTest
+import kotlin.test.Test
+
+class SetNotificationSettingsUseCaseTest {
+
+    private val notificationPrefs: NotificationPrefs = mock()
+    private lateinit var useCase: SetNotificationSettingsUseCase
+
+    @BeforeTest
+    fun setUp() {
+        useCase = SetNotificationSettingsUseCase(notificationPrefs)
+    }
+
+    @Test
+    fun `setMessagesEnabled calls notificationPrefs`() {
+        every { notificationPrefs.setMessagesEnabled(any()) } returns Unit
+        useCase.setMessagesEnabled(true)
+        verify { notificationPrefs.setMessagesEnabled(true) }
+    }
+
+    @Test
+    fun `setNodeEventsEnabled calls notificationPrefs`() {
+        every { notificationPrefs.setNodeEventsEnabled(any()) } returns Unit
+        useCase.setNodeEventsEnabled(false)
+        verify { notificationPrefs.setNodeEventsEnabled(false) }
+    }
+
+    @Test
+    fun `setLowBatteryEnabled calls notificationPrefs`() {
+        every { notificationPrefs.setLowBatteryEnabled(any()) } returns Unit
+        useCase.setLowBatteryEnabled(true)
+        verify { notificationPrefs.setLowBatteryEnabled(true) }
+    }
+}
diff --git a/core/network/build.gradle.kts b/core/network/build.gradle.kts
@@ -67,6 +67,10 @@ kotlin {
             implementation(libs.okhttp3.logging.interceptor)
         }
 
-        commonTest.dependencies { implementation(libs.kotlinx.coroutines.test) }
+        commonTest.dependencies {
+            implementation(libs.kotlinx.coroutines.test)
+            implementation(libs.kotest.assertions)
+            implementation(libs.kotest.property)
+        }
     }
 }