…endency injection

This commit removes the `javax.inject.Qualifier` annotations from the `core:prefs` module as part of the transition to Koin for dependency injection.

Specific changes include:
- Deleted `core/prefs/src/commonMain/kotlin/org/meshtastic/core/prefs/di/Qualifiers.kt` which contained numerous DataStore qualifiers (e.g., `AnalyticsDataStore`, `AppDataStore`, `MapDataStore`).
- Removed the `javax.inject` dependency from `core/prefs/build.gradle.kts`.

Signed-off-by: James Rich <[email protected]>

This commit refactors `libs.versions.toml` to centralize hardcoded versions into the `[versions]` block and removes unused dependencies. It also corrects documentation regarding automatically provided dependencies in build logic conventions.

Specific changes include:
- Centralized versions for `datadog-gradle`, `firebase-crashlytics-gradle`, and `google-services-gradle` by moving them to the `[versions]` block and referencing them in `[libraries]` and `[plugins]`.
- Removed unused `koin-annotations` version and `javax-inject` library definition.
- Updated `docs/BUILD_LOGIC_CONVENTIONS_GUIDE.md` to remove `jetbrains-lifecycle-runtime-compose` from the list of automatically provided `commonMain` dependencies.

Signed-off-by: James Rich <[email protected]>

…ation

This commit updates the build logic conventions to prefer lazy Gradle configuration and reorganizes historical optimization documents into an archive. It also removes unused test dependencies from the version catalog.

Specific changes include:
- **Build Logic Refactoring**: Updated `FlavorResolution.kt` to use `configurations.configureEach` instead of `afterEvaluate` for better configuration performance.
- **Documentation Reorganization**:
    - Moved historical optimization analysis and summary files to a new `docs/archive/` directory.
    - Simplified `docs/BUILD_LOGIC_INDEX.md` to serve as a concise entry point for current conventions.
    - Updated `BUILD_LOGIC_CONVENTIONS_GUIDE.md` with examples of lazy vs. eager task configuration.
- **Guidelines Update**: Added explicit instructions to `AGENTS.md`, `GEMINI.md`, and `.github/copilot-instructions.md` regarding the preference for lazy Gradle APIs (`configureEach`, `withPlugin`) over `afterEvaluate`.
- **Dependency Cleanup**: Removed the unused `truth` library dependency from `gradle/libs.versions.toml` and the `build-logic` configuration.

Signed-off-by: James Rich <[email protected]>

This commit significantly restructures the CI pipeline in `.github/workflows/reusable-check.yml` to separate host-based tasks (linting, unit tests, KMP smoke tests) from Android matrix-based tasks (instrumented tests and assembly). This optimization reduces redundant test execution and improves coverage reporting.

Specific changes include:

- **CI Workflow Refactoring**:
    - Split `reusable-check.yml` into `host-check` (runs once) and `android-check` (runs per API level).
    - Updated `merge-queue.yml` to explicitly enable lint, unit tests, and instrumented tests.
    - Switched from shorthand Gradle tasks (e.g., `lintDebug`) to explicit module paths (e.g., `app:lintFdroidDebug`) for better precision in CI.
    - Consolidated Codecov uploads for unit tests and instrumented tests into their respective jobs.
    - Updated `pull-request.yml` path filtering to ensure infrastructure and configuration changes (e.g., `.github/workflows/**`, `gradle/`, `settings.gradle.kts`) trigger CI.

- **Build Logic**:
    - Updated `FlavorResolution.kt` to use `ProductFlavorAttr` for marketplace attribute matching, improving compatibility with Android Gradle Plugin flavor resolution.
    - Added a legacy marketplace attribute fallback to maintain compatibility during transitions.

- **Documentation**:
    - Updated `AGENTS.md`, `.github/copilot-instructions.md`, `GEMINI.md`, and `testing-and-ci-playbook.md` to reflect the new CI architecture and task naming conventions.
    - Documented Robolectric/Java 17 compatibility constraints (pinning to SDK 34).

- **Dependency & Module Management**:
    - Expanded JVM smoke compilation to include newly added modules like `:core:testing` and `:feature:connections`.
    - Added explicit lint and Kover tasks for `core:barcode`, `core:api`, and `mesh_service_example`.

Signed-off-by: James Rich <[email protected]>

This commit refactors the CI pipeline to optimize caching strategies and introduces a safety check to ensure pull request path filtering remains synchronized with the project structure.

Specific changes include:
- **Cache Optimization**: Configured `gradle/actions/setup-gradle` to use read-only mode for non-trusted branches. Cache writes are now restricted to `main`, `merge_group`, and `gh-readonly-queue/*` refs.
- **Workflow Validation**: Added a `verify-check-changes-filter` job to `pull-request.yml`. This Python-based check ensures that all module roots defined in `settings.gradle.kts` are explicitly covered by the GitHub Actions path filters.
- **PR Targeting**: Updated `pull-request.yml` to target only the `main` branch, removing `develop`.
- **Dependency Graph**: Removed `dependency-graph: generate-and-submit` from the reusable check workflow in favor of optimized cache settings.
- **Documentation**: Updated `AGENTS.md`, `GEMINI.md`, `.github/copilot-instructions.md`, and the testing playbook to reflect the new caching policy and PR targeting rules.
- **Status Reporting**: Updated the `check-workflow-status` job to account for the new filter verification step.

Signed-off-by: James Rich <[email protected]>

…ore flavor resolution

This reverts the lazy configuration migration for marketplace fallback logic to use `afterEvaluate`. This is required because Android Gradle Plugin (AGP) does not immediately initialize the `isCanBeResolved` and `isCanBeConsumed` flags on newly created configurations. Checking them before they are populated breaks dependency resolution for downstream flavor consumers.