Merged
Conversation
…rom app to core:service/androidMain and core:network/androidMain'
… app to core:service/androidMain and core:network/androidMain' as complete
…adio files from app to core:service/androidMain and core:network/androidMain'
…orker/radio files from app to core:service/androidMain and core:network/androidMain'
…rom app to core:service/androidMain and core:network/androidMain'
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4828 +/- ##
==========================================
+ Coverage 13.20% 13.38% +0.18%
==========================================
Files 539 539
Lines 17763 17753 -10
Branches 2651 2651
==========================================
+ Hits 2345 2376 +31
+ Misses 15102 15058 -44
- Partials 316 319 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a major refactor that extracts Android-specific service, worker, and radio connection files from the
appmodule into the newcore:serviceandcore:networkmodules. The goal is to improve code reuse, testability, and maintainability by isolating platform-specific logic and abstracting shared business logic into multiplatform modules. All imports, dependency injections, and references throughout the project have been updated to reflect these moves.The most important changes are:
Service and Worker Extraction:
ServiceandWorkerclasses (such asMeshService,BootCompleteReceiver,ReplyReceiver, etc.) have been moved fromorg.meshtastic.app.servicetoorg.meshtastic.core.serviceand their references updated across the codebase, including the AndroidManifest and all affected Kotlin files. [1] [2] [3] [4] [5] [6] [7] [8]Radio and Network Refactoring:
AndroidRadioInterfaceService, has been moved fromapp/repository/radiotocore/network/radio, and imports updated accordingly. [1] [2]core/network/build.gradle.kts.Dependency Injection and Module Wiring:
CoreNetworkAndroidModuleand updatingProbeTableProviderreferences. [1] [2]Architecture Documentation and Planning:
Minor Improvements and Bugfixes:
Dataobject for commands, and defining minimum firmware version constants inDeviceVersion. [1] [2] [3] [4]This refactor sets the foundation for better multiplatform support, easier testing, and cleaner separation between platform-specific and shared logic.