Skip to content

Add "Exclude MQTT" filter to Nodes view.#4825

Merged
jamesarich merged 8 commits intomeshtastic:mainfrom
VictorioBerra:main
Mar 18, 2026
Merged

Add "Exclude MQTT" filter to Nodes view.#4825
jamesarich merged 8 commits intomeshtastic:mainfrom
VictorioBerra:main

Conversation

@VictorioBerra
Copy link
Copy Markdown
Contributor

@VictorioBerra VictorioBerra commented Mar 17, 2026

My usecase is that I want to toggle MQTT on/off regularly to see who im finding naturally over the air VS the internet.

Today, you can use the nodes view and click a node and check "via MQTT" but you are unable to filter the list of Nodes on that flag.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 17, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jamesarich jamesarich added Needs CLA enhancement New feature or request ui Something to do with the UI of the Android app and removed Needs CLA labels Mar 17, 2026
jamesarich
jamesarich approved these changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@jamesarich jamesarich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice add, thanks!

@jamesarich jamesarich enabled auto-merge March 17, 2026 20:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.44%. Comparing base (1e9e838) to head (24f01dc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...shtastic/core/datastore/UiPreferencesDataSource.kt 33.33% 2 Missing ⚠️
...stic/feature/node/component/NodeFilterTextField.kt 0.00% 2 Missing ⚠️
...htastic/feature/node/list/NodeFilterPreferences.kt 0.00% 2 Missing ⚠️
.../meshtastic/feature/node/list/NodeListViewModel.kt 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4825   +/-   ##
=======================================
  Coverage   13.44%   13.44%           
=======================================
  Files         542      542           
  Lines       17822    17831    +9     
  Branches     2667     2667           
=======================================
+ Hits         2396     2398    +2     
- Misses      15104    15111    +7     
  Partials      322      322
Flag Coverage Δ
host-unit 13.44% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich
Copy link
Copy Markdown
Collaborator

jamesarich commented Mar 17, 2026

Ah @VictorioBerra - looks like it needs a ./gradlew spotlessApply then we can get it in.

@VictorioBerra
Copy link
Copy Markdown
Contributor Author

VictorioBerra commented Mar 17, 2026

Ah @VictorioBerra - looks like it needs a ./gradlew spotlessApply then we can get it in.

I synced my fork, spotlessApply had 0 changes. Anything else for me to do?

@jamesarich
Copy link
Copy Markdown
Collaborator

jamesarich commented Mar 18, 2026

Ah @VictorioBerra - looks like it needs a ./gradlew spotlessApply then we can get it in.

I synced my fork, spotlessApply had 0 changes. Anything else for me to do?

https://github.com/meshtastic/Meshtastic-Android/actions/runs/23219906989/job/67512727906#step:6:267

Spotless is still unhappy.

auto-merge was automatically disabled March 18, 2026 14:47

Head branch was pushed to by a user without write access

auto-merge was automatically disabled March 18, 2026 14:47

Pull request was closed

@VictorioBerra
Copy link
Copy Markdown
Contributor Author

VictorioBerra commented Mar 18, 2026

I clicked "sync" on my fork, not sure why it auto-closed this.

@VictorioBerra VictorioBerra reopened this Mar 18, 2026
@jamesarich
Copy link
Copy Markdown
Collaborator

jamesarich commented Mar 18, 2026 •
edited
Loading

it's still complaining about spotless:

> The following files had format violations:
      src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListViewModel.kt

I'll pull your PR and run a ./gradlew spotlessCheck and see what's up

@VictorioBerra
Copy link
Copy Markdown
Contributor Author

VictorioBerra commented Mar 18, 2026

it's still complaining about spotless:

> The following files had format violations:
      src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListViewModel.kt

I'll pull your PR and run a ./gradlew spotlessCheck and see what's up

Thank you, on my main, my fork is fully synced, git status is clean, and grade spotlessApply reports successful build. Im not sure what I am missing:

image

@jamesarich
Copy link
Copy Markdown
Collaborator

jamesarich commented Mar 18, 2026

huh, not sure why that didn't do it for you @VictorioBerra - running ./gradlew spotlessApply updated the formatting in those two files for me.

I also use Android Studio for development, not sure if vscode sees external file changes unless you refresh 🤷 .

@jamesarich jamesarich enabled auto-merge March 18, 2026 15:33
@jamesarich jamesarich added this pull request to the merge queue Mar 18, 2026
Merged via the queue into meshtastic:main with commit eae5a6b Mar 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesarich jamesarich jamesarich approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request ui Something to do with the UI of the Android app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VictorioBerra @CLAassistant @jamesarich