feat: Integrate notification management and preferences across platforms#4819
Merged
jamesarich merged 34 commits intomainfrom Mar 17, 2026
Merged
feat: Integrate notification management and preferences across platforms#4819jamesarich merged 34 commits intomainfrom
jamesarich merged 34 commits intomainfrom
Conversation
…date implementations
…(androidMain)' as complete
…rviceNotifications
…tings on Android, in-app toggles on Desktop)
…settings link, Desktop uses in-app toggles)
- Delete platform-specific `NotificationSection` implementations for Android and JVM in `feature:settings`, moving toward a shared implementation. - Update `MessageViewModelTest` to include a mocked `NotificationManager` dependency. - Update `DesktopPlatformModule` to synchronize `versionName`, `absoluteMinFwVersion`, and `minFwVersion` with current release standards. - NotificationSection.android.kt: removed Android-specific notification permission launcher. - NotificationSection.jvm.kt: removed JVM-specific notification toggle switches. - MessageViewModelTest.kt: added `notificationManager` mock to `MessageViewModel` instantiation. - DesktopPlatformModule.kt: updated version strings (e.g., `versionName` to "2.7.14").
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4819 +/- ##
==========================================
+ Coverage 12.18% 13.20% +1.01%
==========================================
Files 531 539 +8
Lines 17578 17761 +183
Branches 2630 2651 +21
==========================================
+ Hits 2142 2345 +203
+ Misses 15131 15100 -31
- Partials 305 316 +11 ☔ View full report in Codecov by Sentry. |
Signed-off-by: James Rich <[email protected]>
Removed unused meshServiceNotifications parameter that was removed from the MessageViewModel constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the notification system in the shared Kotlin Multiplatform (KMP) core from the old
MeshServiceNotificationsto a new, unifiedNotificationManagerabstraction. This enables consistent, cross-platform notification handling for both Android and Desktop, and updates all relevant usages in the core data layer.The most important changes are:
New Feature Tracks and Documentation:
Notification System Refactor (Core Data Layer):
MeshServiceNotificationswith the newNotificationManagerabstraction throughout the core data managers (MeshDataHandlerImpl,FromRadioPacketHandlerImpl,MeshActionHandlerImpl, etc.), ensuring all notification dispatches now use the unified interface. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]NotificationManager.dispatch()method with structured notification data, including title, message, category, and other relevant fields. [1] [2] [3] [4]Product Documentation Update: