fix: fix wrong getChannelUrl() call causing loss of "add" flag and un…#4809
Merged
jamesarich merged 1 commit intomeshtastic:mainfrom Mar 16, 2026
Merged
fix: fix wrong getChannelUrl() call causing loss of "add" flag and un…#4809jamesarich merged 1 commit intomeshtastic:mainfrom
jamesarich merged 1 commit intomeshtastic:mainfrom
Conversation
|
|
…expected uppercase URL prefix (meshtastic#4808)
jamesarich
force-pushed
the
channel_share_url_fix
branch
from
4a3ea03 to
9c89b4b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4809 +/- ##
=======================================
Coverage 12.23% 12.23%
=======================================
Files 530 530
Lines 17753 17753
Branches 2652 2652
=======================================
Hits 2172 2172
Misses 15267 15267
Partials 314 314 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
During development of my desktop client I've discovered #4808 in Android client.
It was a very simple to fix bug, so I decided to save you some time and do it myself.
Thanks for making a nice app, BTW ❤️
fixes #4808