feat(desktop): add enter-to-send functionality in messaging#4793
Merged
jamesarich merged 1 commit intomainfrom Mar 14, 2026
Merged
feat(desktop): add enter-to-send functionality in messaging#4793jamesarich merged 1 commit intomainfrom
jamesarich merged 1 commit intomainfrom
Conversation
This commit introduces a desktop-friendly keyboard shortcut for sending messages. Users can now press `Enter` to send a message and `Shift + Enter` to insert a newline. Specific changes include: - Implemented `onPreviewKeyEvent` on the `MessageInput` component in `DesktopMessageContent.kt`. - Added logic to validate message length against `MESSAGE_CHARACTER_LIMIT_BYTES` before sending via `Enter`. - Ensured messages are only sent if the connection is active and the trimmed message is not empty. - Configured the event handler to consume the `Enter` key (preventing newlines) when the user attempts to send, while allowing standard newline behavior when `Shift` is pressed. Signed-off-by: James Rich <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a desktop-friendly keyboard shortcut for sending messages. Users can now press
Enterto send a message andShift + Enterto insert a newline.Specific changes include:
onPreviewKeyEventon theMessageInputcomponent inDesktopMessageContent.kt.MESSAGE_CHARACTER_LIMIT_BYTESbefore sending viaEnter.Enterkey (preventing newlines) when the user attempts to send, while allowing standard newline behavior whenShiftis pressed.