build: Update desktop app icons, versioning, and packaging configuration#4789
Merged
jamesarich merged 2 commits intomainfrom Mar 14, 2026
Merged
build: Update desktop app icons, versioning, and packaging configuration#4789jamesarich merged 2 commits intomainfrom
jamesarich merged 2 commits intomainfrom
Conversation
- Update macOS and Windows packaging configurations to use platform-native `.icns` and `.ico` icon files. - Add `icon.icns` and `icon.ico` to desktop resources and update the existing `icon.png`. - Refine version resolution logic to prioritize `android.injected.version.name` and the `VERSION_NAME` environment variable. - Update the default fallback version from `0.1.0` to `1.0.0`. Signed-off-by: James Rich <[email protected]>
This commit enhances the Compose Multiplatform desktop packaging configuration to improve runtime stability, performance, and cross-platform metadata.
Specific changes include:
- **JVM Runtime**: Expanded the list of bundled modules (e.g., `jdk.crypto.ec`, `java.sql`, `java.naming`) to ensure compatibility with Ktor, SSL/TLS, and SQLite.
- **Resource Management**: Increased the default maximum heap size to 2GB (`-Xmx2G`) to prevent OOM issues.
- **Platform Metadata**:
- Added `menuGroup` configurations for Windows and Linux.
- Updated the default fallback version from `0.1.0` to `1.0.0`.
- Added placeholders and documentation for macOS signing/notarization and Windows upgrade UUIDs.
- **Build Optimization**: Added a commented-out ProGuard configuration with a warning regarding testing requirements for serialization and JNI.
Signed-off-by: James Rich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the desktop build configuration to improve packaging, compatibility, and distribution readiness for the Meshtastic Desktop application. The changes focus on ensuring all necessary JVM modules are included, improving OS-specific packaging, and clarifying ProGuard usage and versioning.
Packaging and JVM configuration improvements:
jdk.crypto.ec,jdk.unsupported,java.sql, andjava.naming) in the custom JRE to ensure compatibility with dependencies like Ktor and SQLite, especially when modules are loaded via reflection or JNI.OS-specific packaging enhancements:
.icnsfor macOS,.icofor Windows,.pngfor Linux), and added placeholders for future macOS signing/notarization and Windows upgrade UUIDs.Build and distribution notes:
1.0.0if unavailable, and enforced strict semantic versioning for native installers.