Disable ProGuard for desktop release and add application icon#4776
Merged
jamesarich merged 2 commits intomainfrom Mar 13, 2026
Merged
Disable ProGuard for desktop release and add application icon#4776jamesarich merged 2 commits intomainfrom
jamesarich merged 2 commits intomainfrom
Conversation
This commit disables ProGuard obfuscation/optimization for the desktop release build type while retaining the reference to the configuration file. Specific changes: - Set `isEnabled.set(false)` within the `buildTypes.release.proguard` configuration in `desktop/build.gradle.kts`. Signed-off-by: James Rich <[email protected]>
This commit adds a new application icon and configures the desktop build and runtime to use it across macOS, Windows, and Linux. Specific changes include: - Added `icon.png` to the desktop resource directory. - Updated `build.gradle.kts` to set the `iconFile` for macOS, Windows, and Linux native distributions. - Updated `Main.kt` to set the window icon using the new resource. Signed-off-by: James Rich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes improvements to the Meshtastic Desktop application's build configuration and user interface, focusing on packaging and branding. The main changes include disabling Proguard for release builds, setting platform-specific app icons for installers, and updating the app window to display the icon.
Packaging and build configuration:
isEnabledto false indesktop/build.gradle.kts, which prevents code obfuscation and simplifies debugging.desktop/build.gradle.kts, ensuring the application uses the correct icon in installers.User interface and branding:
painterResourceindesktop/src/main/kotlin/org/meshtastic/desktop/Main.ktto enable loading the app icon.painterResource("icon.png").