refactor: migrate core UI and features to KMP, adopt Navigation 3#4750
Merged
jamesarich merged 1 commit intomainfrom Mar 10, 2026
Merged
refactor: migrate core UI and features to KMP, adopt Navigation 3#4750jamesarich merged 1 commit intomainfrom
jamesarich merged 1 commit intomainfrom
Conversation
- Migrate `core:ui`, `feature:node`, and `feature:settings` UI components, screens, and view models from `androidMain` to `commonMain`. - Migrate app routing to AndroidX Navigation 3, replacing `NavHostController` and `composable` with `NavBackStack`, `NavKey`, and `EntryProviderScope` across all navigation graphs (`NodesNavigation`, `SettingsNavigation`, `ContactsNavigation`, etc.). - Introduce `expect`/`actual` KMP abstractions for platform-specific utilities, including `ClipboardUtils`, `Base64Factory`, `UrlUtils`, `NumberFormatter`, `DateFormatter`, `QrUtils`, and `PlatformUtils`. - Refactor `AutoLinkText` to use pure Kotlin Regex and `buildAnnotatedString` instead of Android's `Linkify`. - Abstract Android-specific implementations such as intents (Maps, NFC settings, browser, toasts) and QR code rendering into platform-specific implementations. - Remove Android-only `@Preview` annotations from shared UI components. - Update module build scripts to include `androidx.navigation3.runtime` and `androidx.navigation3.ui`, removing legacy Jetpack Navigation Compose dependencies. - Add comprehensive documentation, including a 2026 KMP progress review, evidence appendix, migration plans for Koin and BLE, and AI agent playbooks for codebase conventions. Signed-off-by: James Rich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core:ui,feature:node, andfeature:settingsUI components, screens, and view models fromandroidMaintocommonMain.NavHostControllerandcomposablewithNavBackStack,NavKey, andEntryProviderScopeacross all navigation graphs (NodesNavigation,SettingsNavigation,ContactsNavigation, etc.).expect/actualKMP abstractions for platform-specific utilities, includingClipboardUtils,Base64Factory,UrlUtils,NumberFormatter,DateFormatter,QrUtils, andPlatformUtils.AutoLinkTextto use pure Kotlin Regex andbuildAnnotatedStringinstead of Android'sLinkify.@Previewannotations from shared UI components.androidx.navigation3.runtimeandandroidx.navigation3.ui, removing legacy Jetpack Navigation Compose dependencies.