refactor: enhance handshake stall guard and extend coverage to Stage 2#4730
Merged
jamesarich merged 1 commit intomainfrom Mar 5, 2026
Merged
refactor: enhance handshake stall guard and extend coverage to Stage 2#4730jamesarich merged 1 commit intomainfrom
jamesarich merged 1 commit intomainfrom
Conversation
- Extract handshake timeout and retry logic into a reusable `startHandshakeStallGuard` function. - Apply the stall guard to both `startConfigOnly` (Stage 1) and `startNodeInfoOnly` (Stage 2) to ensure connection attempts don't hang. - Increase `HANDSHAKE_TIMEOUT` from 10 seconds to 30 seconds to reduce false-positive stall detections on slower links. Signed-off-by: James Rich <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4730 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 231 231
Branches 34 34
=====================================
Misses 231 231 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startHandshakeStallGuardfunction.startConfigOnly(Stage 1) andstartNodeInfoOnly(Stage 2) to ensure connection attempts don't hang.HANDSHAKE_TIMEOUTfrom 10 seconds to 30 seconds to reduce false-positive stall detections on slower links.