Align FDroid MapView constructor with Google version (Issue #4576)#4630
Merged
jamesarich merged 2 commits intomeshtastic:mainfrom Feb 25, 2026
Merged
Align FDroid MapView constructor with Google version (Issue #4576)#4630jamesarich merged 2 commits intomeshtastic:mainfrom
jamesarich merged 2 commits intomeshtastic:mainfrom
Conversation
|
|
jamesarich
approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4630 +/- ##
=======================================
Coverage 16.27% 16.27%
=======================================
Files 80 80
Lines 4036 4036
Branches 699 699
=======================================
Hits 657 657
Misses 3255 3255
Partials 124 124 ☔ View full report in Codecov by Sentry. |
Collaborator
|
@ujade you'll need to sign the CLA before we can accept this PR, thanks! |
Contributor
Author
Missed this- signed. |
Collaborator
|
Thanks for the contrib - do reach out on discord if you want to continue contribution, we can get you better looped in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #4576. The MapView constructor in the FDroid does not share a function definition with the Google variant which causes the app to crash (No function with that definition found) when opening the map from a traceroute. Could not reproduce scanning QR codes causing a crash.
Tested on Google Pixel 9a running GrapheneOS 2026021200