Skip to content

fix(strings): Correct capitalization of Ham#4620

Merged
jamesarich merged 1 commit intomeshtastic:mainfrom
alecperkins:fix/typo
Feb 26, 2026
Merged

fix(strings): Correct capitalization of Ham#4620
jamesarich merged 1 commit intomeshtastic:mainfrom
alecperkins:fix/typo

Conversation

@alecperkins
Copy link
Copy Markdown
Contributor

In reference to amateur radio operators, “ham” is not an acronym.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 22, 2026

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the bugfix PR tag label Feb 22, 2026
@jamesarich
Copy link
Copy Markdown
Collaborator

We only need the English string, translations are sourced by Crowdin.

@alecperkins
Copy link
Copy Markdown
Contributor Author

alecperkins commented Feb 22, 2026

Updated, though I wonder if it will translate properly, or perhaps be too literal? I don’t know if "ham" is used in every language this way.

For comparison, the option on iOS: image

@jamesarich
Copy link
Copy Markdown
Collaborator

Updated, though I wonder if it will translate properly, or perhaps be too literal? I don’t know if "ham" is used in every language this way.

For comparison, the option on iOS: image

I can add a contextual note to that string for translators, I'll include a ref to this ticket.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.36%. Comparing base (3585422) to head (62960b1).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4620   +/-   ##
=======================================
  Coverage   15.36%   15.36%           
=======================================
  Files          83       83           
  Lines        4342     4342           
  Branches      734      734           
=======================================
  Hits          667      667           
  Misses       3551     3551           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesarich
Copy link
Copy Markdown
Collaborator

Hi @alecperkins this is now in conflict, would you like to fix it up?

@jamesarich jamesarich enabled auto-merge February 26, 2026 23:11
@jamesarich jamesarich added this pull request to the merge queue Feb 26, 2026
Merged via the queue into meshtastic:main with commit 728ef0c Feb 26, 2026
7 checks passed
@jamesarich
Copy link
Copy Markdown
Collaborator

@alecperkins added a comment on Crowdin:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR tag

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants