Fix add qr acting like replace instead of add#3823
Merged
jamesarich merged 2 commits intomeshtastic:mainfrom Nov 26, 2025
Merged
Fix add qr acting like replace instead of add#3823jamesarich merged 2 commits intomeshtastic:mainfrom
jamesarich merged 2 commits intomeshtastic:mainfrom
Conversation
Collaborator
|
does 3464 match what you were seeing ? My memory is that it was doing nothing, but I would have used an Android QR code, so maybe they're different bugs. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3823 +/- ##
========================================
- Coverage 0.54% 0.54% -0.01%
========================================
Files 386 386
Lines 22525 22531 +6
Branches 2828 2829 +1
========================================
Hits 122 122
- Misses 22382 22388 +6
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3464 ??
There was a major bug that made a add channel actually replace all channels instead. The only thing that worked correctly was add would not override the lora settings.
This is what happened when I would share just one channel from iOS to Android
