Skip to content

fix: inconsistent text color in 'use meshery playground' + or - #2669

Merged
saurabhraghuvanshii merged 3 commits into
meshery:masterfrom
icoderarely:fix/inconsistent-text-color-19143
May 17, 2026
Merged

saurabhraghuvanshii merged 3 commits into
meshery:masterfrom
icoderarely:fix/inconsistent-text-color-19143

Conversation

@icoderarely

Copy link
Copy Markdown
Contributor

Description

This PR fixes meshery/meshery#19143

Notes for Reviewers

  • The "Use Meshery Playground" heading uses the same dark text color styling as the other section headings on the page to maintain visual consistency and readability.
  • Also fixed 'OR' to work with light/dark mode while maintaining the consistency of font-color with theme.

Dark Mode
image

Light Mode
image

Signed commits

  • Yes, I signed my commits.

@netlify

netlify Bot commented May 11, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit a56672f
🔍 Latest deploy log https://app.netlify.com/projects/mesheryio-preview/deploys/6a09a6b77d4fc40008969220
😎 Deploy Preview https://deploy-preview-2669--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for PR #2669 removed.

This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits.

If needed, push a new commit to this PR to generate a fresh preview.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'Getting Started' section by converting a step heading from a span to an h2 element and removing a hardcoded color style from the 'OR' separator. Feedback was provided to correct the CSS for centering the 'OR' text, suggesting the use of text-align: center instead of justify-content: center, which is ineffective on non-flex containers.

Comment thread _includes/getting-started.html Resolved

@rishiraj38 rishiraj38 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!!!!!!!!!

@icoderarely

Copy link
Copy Markdown
Contributor Author

Thank you @rishiraj38 @Rajesh-Nagarajan-11

@rishiraj38

Copy link
Copy Markdown
Contributor

@saurabhraghuvanshii, please take a look when you get a chance.

@saurabhraghuvanshii
saurabhraghuvanshii merged commit 650adb1 into meshery:master May 17, 2026
5 of 8 checks passed
@welcome

welcome Bot commented May 17, 2026

Copy link
Copy Markdown

Thanks for your contribution to the Meshery community! 🎉

Meshery Logo
        ⭐ Please leave a star on the project. 😄

@saurabhraghuvanshii

Copy link
Copy Markdown
Member

thanks @icoderarely lgtm!!

@icoderarely
icoderarely deleted the fix/inconsistent-text-color-19143 branch May 18, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent text color in "Use Meshery Playground" heading on Getting Started page

4 participants