Repository navigation
[UI] Migrate Sistent icon imports to append Icon suffix - #19735
Merged
Merged
Conversation
Signed-off-by: Lenox Wiltshire <[email protected]>
Signed-off-by: Rishi Raj <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes icon imports and usage across various UI components, replacing legacy or aliased icon names (such as AccessTime, BarchartIcon, GroupAdd, InfoOutlined, ChevronLeft, and ChevronRight) with their canonical *Icon equivalents from @sistent/sistent. The review feedback suggests improving naming consistency in YamlDialog.tsx by using FullScreenIcon with a capital 'S' instead of aliasing it to FullscreenIcon with a lowercase 's', matching the convention of FullScreenExitIcon.
…nto fix-sistent-icon-imports Signed-off-by: Rishi Raj <[email protected]> # Conflicts: # ui/components/workspaces/WorkspaceGridView.test.tsx
Signed-off-by: Rishi Raj <[email protected]>
1 task done
Signed-off-by: Rishi Raj <[email protected]>
Rajesh-Nagarajan-11
left a comment
Rajesh-Nagarajan-11
left a comment
Member
There was a problem hiding this comment.
This PR also includes the upgrade to Sistent v0.24.15.
Contributor
|
Commit SHA: END-TO-END TESTS
📦 Test Result Summary
⌛ Duration: 11 minutes and 32 seconds Overall Result: 👎 Some tests failed. [Show/Hide] Test Result Details
❌ Failed Test Details The following tests failed. Click on each to see the failure reason: ❌ Grafana elements on metrics tab (Local - chromium-local-provider)File Location: Error Message: Code Snippet: ❌ Create a Model (Local - chromium-local-provider)File Location: Error Message: 🔗 Relationship Tests [Show/Hide] Relationship Test Details (18 tests)
|
Junnygram
approved these changes
May 27, 2026
Junnygram
left a comment
Junnygram
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
I've checked out this branch locally and verified all icon migrations and corresponding test mock definitions:
- Icon suffix renaming:
AccessTimeIcon,ChevronLeftIcon,ChevronRightIcon,FullScreenExitIcon,GroupAddIcon,BarChartIcon, andInfoOutlinedIconare correctly integrated across all pages, layouts, and workspace components. - Chevron migrations: Confirmed that the recent merge of
feature/banana-three-join/chevronicon-sistent-updateresolved the outstanding Chevron icon upgrades in the workspace views. - Unit Tests: Ran the UI unit test suite locally; all mock definitions targeting
@sistent/sistentmock exports are correct and tests are compiling and passing without issues.
Rajesh-Nagarajan-11
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the imports and usages of Sistent components/icons in the Meshery UI codebase to conform to the updated
@sistent/sistenticon naming schema, appending theIconsuffix to the following components:AccessTime->AccessTimeIconChevronLeft->ChevronLeftIconChevronRight->ChevronRightIconFullScreenIconExit->FullScreenExitIconGroupAdd->GroupAddIconBarchartIcon->BarChartIconInfoOutlined->InfoOutlinedIconAdditionally, all corresponding unit test mock definitions targeting
@sistent/sistentexports and custom component imports have been updated to prevent test failures due to missing mock exports.Key Changes
@sistent/sistentrather than local components where applicable.InfoOutlinedIconmock names).Signed commits