Repository navigation
[CI] Recompile docs-noob-tester lock file to fix AWF firewall 404 - #19209
Conversation
Signed-off-by: Rishi Raj <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the actions-lock.json file, modifying the version keys and SHAs for the github-script and setup actions. The review feedback highlights that changing these version keys without corresponding updates in the workflow files will likely cause CI failures, as lock file resolution requires an exact match between the workflow's uses string and the lock file key. Additionally, the change from v9 to v9.0.0 for github-script introduces a formatting inconsistency compared to other entries in the file.
|
@leecalcote @Junnygram Please take a look. |
|
Since this PR was merged, this is just the lock file recompilation now. |
|
Hey @rishiraj38 @Junnygram, Went through the current workflow codebase and also reviewed #19236 to understand the recent first-time contributor workflow hardening. I noticed that Meshery has a high volume of open PRs. I was exploring whether a review-stage structure could help make the PR queue easier to triage, for example with labels or automation around states like Do you think this kind of review-stage taxonomy or automation would be useful for Meshery? |
…rsion [CI] Recompile docs-noob-tester lock file to fix AWF firewall 404
Notes for Reviewers
Fixes the Docs Noob Tester workflow (run #43) failing at "Install AWF binary".
The lock file was compiled with
gh aw v0.71.1which pinnedgh-aw-firewalltov0.25.28— a version that no longer exists, causing a 404 during download. This is a known upstream bug (#30705).Recompiled the lock file with
gh aw v0.71.5which pins to firewallv0.25.40.Signed commits