Skip to content

[UI] Replace direct MUI imports in root UI primitives and utility surfaces - #19126

Merged
hortison merged 3 commits into
meshery:masterfrom
rishiraj38:replaces_direct_mui_imports
May 7, 2026
Merged

hortison merged 3 commits into
meshery:masterfrom
rishiraj38:replaces_direct_mui_imports

Conversation

@rishiraj38

Copy link
Copy Markdown
Contributor

Description

Swaps all remaining direct @mui/* icon imports across 13 scoped root-level components and utility files with their @sistent/sistent equivalents. Also migrates the mui-datatables type import in MesheryCredentialComponent to @sistent/mui-datatables.

No visual or behavioral changes — just cleaning up import sources as part of the Phase 2 theme restructure (#18657).

Files changes: ViewSwitch, ReactSelectWrapper, YamlDialog,`` MesheryChart, MesheryAdapterPlayComponent, MesheryPlayComponent, MesherySettingsEnvButtons, DataFormatter/index, MesheryCredentialComponent.

Fixes #18732

Signed commits

  • Yes, I signed my commits.

@github-actions github-actions Bot added the component/ui User Interface label May 6, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors multiple UI components to consolidate icon imports by moving them from individual @mui/icons-material imports to the centralized @sistent/sistent library. This change improves code organization and consistency across the project. I have no feedback to provide.

@rishiraj38
rishiraj38 had a problem deploying to staging-playground May 6, 2026 08:07 — with GitHub Actions Failure
@rishiraj38
rishiraj38 temporarily deployed to staging-playground May 6, 2026 15:20 — with GitHub Actions Inactive
@rishiraj38
rishiraj38 temporarily deployed to staging-playground May 7, 2026 15:23 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Commit SHA: ef10a033213957bcb0c27fba01cda23c7bb05d98

END-TO-END TESTS

  • Testing started at: May 7th 2026, 3:36:31 pm

📦 Test Result Summary

  • ✅ 133 passed
  • ❌ 4 failed
  • ⚠️ 0 flaked
  • ⏩ 7 skipped

⌛ Duration: 7 minutes and 20 seconds

Overall Result: 👎 Some tests failed.

[Show/Hide] Test Result Details
Test Provider Browser Test Case Tags Result
1 Meshery chromium-meshery-provider Action buttons on adapters tab ✅
2 Meshery chromium-meshery-provider Aggregation Charts are displayed ✅
3 Meshery chromium-meshery-provider alias resolution relationship ✅
4 Meshery chromium-meshery-provider alias resolution relationship ✅
5 Meshery chromium-meshery-provider alias resolution relationship ✅
6 Meshery chromium-meshery-provider alias resolution relationship ✅
7 Meshery chromium-meshery-provider alias resolution relationship ✅
8 Meshery chromium-meshery-provider alias resolution relationship ✅
9 Meshery chromium-meshery-provider alias resolution relationship ✅
10 Meshery chromium-meshery-provider alias resolution relationship ✅
11 Meshery chromium-meshery-provider alias resolution relationship ✅
12 Meshery chromium-meshery-provider All settings tabs ✅
13 Meshery chromium-meshery-provider Common UI elements ✅
14 Meshery chromium-meshery-provider config patching correctness relationship ✅
15 Meshery chromium-meshery-provider config patching correctness relationship ✅
16 Meshery chromium-meshery-provider config patching correctness relationship ✅
17 Meshery chromium-meshery-provider config patching correctness relationship ✅
18 Meshery chromium-meshery-provider config patching correctness relationship ✅
19 Meshery chromium-meshery-provider config patching correctness relationship ✅
20 Meshery chromium-meshery-provider config patching correctness relationship ✅
21 Meshery chromium-meshery-provider config patching correctness relationship ✅
22 Meshery chromium-meshery-provider config patching correctness relationship ✅
23 Meshery chromium-meshery-provider Configure Existing Istio adapter through Mesh Adapter URL from Management page unstable ⚠️
24 Meshery chromium-meshery-provider Connect to Meshery Istio Adapter and configure it ➖
25 Meshery chromium-meshery-provider Create a Model ✅
26 Meshery chromium-meshery-provider Delete Kubernetes cluster connections ❌
27 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
28 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
29 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
30 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
31 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
32 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
33 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
34 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
35 Meshery chromium-meshery-provider evaluation idempotency relationship ✅
36 Meshery chromium-meshery-provider Grafana elements on metrics tab ✅
37 Meshery chromium-meshery-provider Import a Model via CSV Import ➖
38 Meshery chromium-meshery-provider Import a Model via File Import ❌
39 Meshery chromium-meshery-provider Import a Model via Url Import ➖
40 Meshery chromium-meshery-provider Logout from current user session ✅
41 Meshery chromium-meshery-provider Ping Istio Adapter unstable ⚠️
42 Meshery chromium-meshery-provider Search a Model and Export it ✅
43 Meshery chromium-meshery-provider should edit design in Design Configurator ✅
44 Meshery chromium-meshery-provider should identify relationships for All Relationships relationship ✅
45 Meshery chromium-meshery-provider should identify relationships for Container-Hierarchical-Parent-Alias-Relationship relationship ✅
46 Meshery chromium-meshery-provider should identify relationships for deployment-configmap-reference-relationship relationship ✅
47 Meshery chromium-meshery-provider should identify relationships for Hierarchical-Parent-Namespace-Relationship relationship ✅
48 Meshery chromium-meshery-provider should identify relationships for meshery-design relationship ✅
49 Meshery chromium-meshery-provider should identify relationships for pv-pvc-edge-non-binding-reference-relationship relationship ✅
50 Meshery chromium-meshery-provider should identify relationships for Service-To-Deployment-Network relationship ✅
51 Meshery chromium-meshery-provider should verify Design Configurator page elements ✅
52 Meshery chromium-meshery-provider structural integrity relationship ✅
53 Meshery chromium-meshery-provider structural integrity relationship ✅
54 Meshery chromium-meshery-provider structural integrity relationship ✅
55 Meshery chromium-meshery-provider structural integrity relationship ✅
56 Meshery chromium-meshery-provider structural integrity relationship ✅
57 Meshery chromium-meshery-provider structural integrity relationship ✅
58 Meshery chromium-meshery-provider structural integrity relationship ✅
59 Meshery chromium-meshery-provider structural integrity relationship ✅
60 Meshery chromium-meshery-provider structural integrity relationship ✅
61 Meshery chromium-meshery-provider Test if Left Navigation Panel is displayed ✅
62 Meshery chromium-meshery-provider Test if Notification button is displayed ✅
63 Meshery chromium-meshery-provider Test if Profile button is displayed ✅
64 Meshery chromium-meshery-provider Toggle "Send Anonymous Performance Results" ✅
65 Meshery chromium-meshery-provider Toggle "Send Anonymous Usage Statistics" ✅
66 Meshery chromium-meshery-provider Verify Kanvas Details ✅
67 Meshery chromium-meshery-provider Verify Kanvas Snapshot UI elements ❌
68 Meshery chromium-meshery-provider Verify Meshery Adapter for Istio Section ✅
69 Meshery chromium-meshery-provider Verify Meshery Catalog Section Details ✅
70 Meshery chromium-meshery-provider Verify Meshery Design Embed Details ✅
71 Meshery chromium-meshery-provider Verify Meshery Docker Extension Details ✅
72 Meshery chromium-meshery-provider Verify Performance Analysis Details ✅
73 Meshery chromium-meshery-provider Verify that UI components are displayed ✅
74 None chromium-local-provider Action buttons on adapters tab ✅
75 None chromium-local-provider Aggregation Charts are displayed ✅
76 None chromium-local-provider alias resolution relationship ✅
77 None chromium-local-provider alias resolution relationship ✅
78 None chromium-local-provider alias resolution relationship ✅
79 None chromium-local-provider alias resolution relationship ✅
80 None chromium-local-provider alias resolution relationship ✅
81 None chromium-local-provider alias resolution relationship ✅
82 None chromium-local-provider alias resolution relationship ✅
83 None chromium-local-provider alias resolution relationship ✅
84 None chromium-local-provider alias resolution relationship ✅
85 None chromium-local-provider All settings tabs ✅
86 None chromium-local-provider Common UI elements ✅
87 None chromium-local-provider config patching correctness relationship ✅
88 None chromium-local-provider config patching correctness relationship ✅
89 None chromium-local-provider config patching correctness relationship ✅
90 None chromium-local-provider config patching correctness relationship ✅
91 None chromium-local-provider config patching correctness relationship ✅
92 None chromium-local-provider config patching correctness relationship ✅
93 None chromium-local-provider config patching correctness relationship ✅
94 None chromium-local-provider config patching correctness relationship ✅
95 None chromium-local-provider config patching correctness relationship ✅
96 None chromium-local-provider Configure Existing Istio adapter through Mesh Adapter URL from Management page unstable ⚠️
97 None chromium-local-provider Connect to Meshery Istio Adapter and configure it ➖
98 None chromium-local-provider Create a Model ✅
99 None chromium-local-provider Delete Kubernetes cluster connections ➖
100 None chromium-local-provider evaluation idempotency relationship ✅
101 None chromium-local-provider evaluation idempotency relationship ✅
102 None chromium-local-provider evaluation idempotency relationship ✅
103 None chromium-local-provider evaluation idempotency relationship ✅
104 None chromium-local-provider evaluation idempotency relationship ✅
105 None chromium-local-provider evaluation idempotency relationship ✅
106 None chromium-local-provider evaluation idempotency relationship ✅
107 None chromium-local-provider evaluation idempotency relationship ✅
108 None chromium-local-provider evaluation idempotency relationship ✅
109 None chromium-local-provider Grafana elements on metrics tab ✅
110 None chromium-local-provider Import a Model via CSV Import ➖
111 None chromium-local-provider Import a Model via File Import ❌
112 None chromium-local-provider Import a Model via Url Import ➖
113 None chromium-local-provider Logout from current user session ✅
114 None chromium-local-provider Ping Istio Adapter unstable ⚠️
115 None chromium-local-provider Search a Model and Export it ✅
116 None chromium-local-provider should edit design in Design Configurator ✅
117 None chromium-local-provider should identify relationships for All Relationships relationship ✅
118 None chromium-local-provider should identify relationships for Container-Hierarchical-Parent-Alias-Relationship relationship ✅
119 None chromium-local-provider should identify relationships for deployment-configmap-reference-relationship relationship ✅
120 None chromium-local-provider should identify relationships for Hierarchical-Parent-Namespace-Relationship relationship ✅
121 None chromium-local-provider should identify relationships for meshery-design relationship ✅
122 None chromium-local-provider should identify relationships for pv-pvc-edge-non-binding-reference-relationship relationship ✅
123 None chromium-local-provider should identify relationships for Service-To-Deployment-Network relationship ✅
124 None chromium-local-provider should verify Design Configurator page elements ✅
125 None chromium-local-provider structural integrity relationship ✅
126 None chromium-local-provider structural integrity relationship ✅
127 None chromium-local-provider structural integrity relationship ✅
128 None chromium-local-provider structural integrity relationship ✅
129 None chromium-local-provider structural integrity relationship ✅
130 None chromium-local-provider structural integrity relationship ✅
131 None chromium-local-provider structural integrity relationship ✅
132 None chromium-local-provider structural integrity relationship ✅
133 None chromium-local-provider structural integrity relationship ✅
134 None chromium-local-provider Test if Left Navigation Panel is displayed ✅
135 None chromium-local-provider Test if Notification button is displayed ✅
136 None chromium-local-provider Test if Profile button is displayed ✅
137 None chromium-local-provider Toggle "Send Anonymous Performance Results" ✅
138 None chromium-local-provider Toggle "Send Anonymous Usage Statistics" ✅
139 None chromium-local-provider Verify Kanvas Details ✅
140 None chromium-local-provider Verify Kanvas Snapshot UI elements ✅
141 None chromium-local-provider Verify Meshery Adapter for Istio Section ✅
142 None chromium-local-provider Verify Meshery Catalog Section Details ✅
143 None chromium-local-provider Verify Meshery Design Embed Details ✅
144 None chromium-local-provider Verify Meshery Docker Extension Details ✅
145 None chromium-local-provider Verify Performance Analysis Details ✅
146 None chromium-local-provider Verify that UI components are displayed ✅
147 None local-setup authenticate as None provider ✅
148 None remote-setup authenticate with Remote Provider ✅

❌ Failed Test Details

The following tests failed. Click on each to see the failure reason:

❌ Verify Kanvas Snapshot UI elements (Meshery - chromium-meshery-provider)

File Location: Not Found

Error Message:

�[31mTest timeout of 60000ms exceeded.�[39m
❌ Delete Kubernetes cluster connections (Meshery - chromium-meshery-provider)

File Location: /home/runner/work/meshery/meshery/ui/tests/e2e/utils/waitForSnackBar.ts

Error Message:

Error: �[2mexpect(�[22m�[31mlocator�[39m�[2m).�[22mtoBeVisible�[2m(�[22m�[2m)�[22m failed

Locator: locator('text=Connection status updated').first()
Expected: visible
Timeout: 60000ms
Error: element(s) not found

Call log:
�[2m  - Expect "toBeVisible" with timeout 60000ms�[22m
�[2m  - waiting for locator('text=Connection status updated').first()�[22m

Code Snippet:

   at utils/waitForSnackBar.ts:5

�[0m �[90m 3 |�[39m �[36mexport�[39m �[36mconst�[39m waitForSnackBar �[33m=�[39m �[36masync�[39m (page�[33m:�[39m �[33mPage�[39m�[33m,�[39m message�[33m:�[39m string)�[33m:�[39m �[33mPromise�[39m�[33m<�[39m�[36mvoid�[39m�[33m>�[39m �[33m=>�[39m {
 �[90m 4 |�[39m   �[36mconst�[39m snackbar �[33m=�[39m page�[33m.�[39mlocator(�[32m`text=${message}`�[39m)�[33m.�[39mfirst()�[33m;�[39m
�[31m�[1m>�[22m�[39m�[90m 5 |�[39m   �[36mawait�[39m expect(snackbar)�[33m.�[39mtoBeVisible()�[33m;�[39m
 �[90m   |�[39m                          �[31m�[1m^�[22m�[39m
 �[90m 6 |�[39m   �[36mawait�[39m snackbar�[33m.�[39mwaitFor({ state�[33m:�[39m �[32m'detached'�[39m�[33m,�[39m timeout�[33m:�[39m �[35m10000�[39m })�[33m;�[39m
 �[90m 7 |�[39m }�[33m;�[39m
 �[90m 8 |�[39m�[0m
❌ Import a Model via File Import (Meshery - chromium-meshery-provider)

File Location: Not Found

Error Message:

�[31mTest timeout of 60000ms exceeded.�[39m
❌ Import a Model via File Import (None - chromium-local-provider)

File Location: Not Found

Error Message:

�[31mTest timeout of 60000ms exceeded.�[39m

🔗 Relationship Tests

[Show/Hide] Relationship Test Details (18 tests)
Kind Type SubType From To Model Design Name Status
edge binding permission ClusterRole ServiceAccount kubernetes Understanding Relationships ✅
edge binding permission Role ServiceAccount kubernetes Understanding Relationships ✅
edge non-binding network Service Deployment kubernetes service-to-deployment-network ✅
edge non-binding network Service Deployment kubernetes meshery-design-fixture.json ✅
edge non-binding reference ClusterRoleBinding ClusterRole kubernetes meshery-design-fixture.json ❌
hierarchical parent alias Container Deployment kubernetes container-hierarchical-parent-alias-relationship ✅
hierarchical parent alias Container Deployment kubernetes deployment-configmap-reference-relationship ✅
hierarchical parent alias Container Deployment kubernetes service-to-deployment-network ✅
hierarchical parent alias Container Deployment kubernetes meshery-design-fixture.json ✅
hierarchical parent alias Container Deployment kubernetes Understanding Relationships ✅
hierarchical parent alias Container Pod kubernetes container-hierarchical-parent-alias-relationship ✅
hierarchical parent inventory * Namespace kubernetes hierarchical-parent-namespace-relationship ✅
hierarchical parent inventory * Namespace kubernetes service-to-deployment-network ✅
hierarchical parent inventory * Namespace kubernetes pv-pvc-edge-non-binding-reference-relationship ✅
hierarchical parent inventory * Namespace kubernetes Understanding Relationships ✅
hierarchical sibling matchlabels ClusterRole ClusterRole kubernetes meshery-design-fixture.json ✅
hierarchical sibling matchlabels Deployment Deployment kubernetes meshery-design-fixture.json ✅
hierarchical sibling matchlabels Service Service kubernetes meshery-design-fixture.json ✅

@leecalcote leecalcote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hortison hortison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hortison
hortison merged commit ba8d3b3 into meshery:master May 7, 2026
7 checks passed

This branch was previously deployed

1 inactive deployment
staging-playground — ef10a033 Deployed May 7, 2026 by rishiraj38 via UI end-to-end tests #21129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/ui User Interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Replace direct MUI imports in root UI primitives and utility surfaces

3 participants