Skip to content

create and update rtree spatial index only when needed#179

Merged
Corvince merged 1 commit intomesa:mainfrom
wang-boyu:agentlayer/spatial-index
Jan 4, 2024
Merged

create and update rtree spatial index only when needed#179
Corvince merged 1 commit intomesa:mainfrom
wang-boyu:agentlayer/spatial-index

Conversation

@wang-boyu
Copy link
Copy Markdown
Member

@wang-boyu wang-boyu commented Dec 24, 2023 •
edited
Loading

Implements #104

Check performance of the gis example models. Execution time is the average of 10 runs, where each run contains model initialization followed by 10 steps.

model time in seconds time in seconds (this PR)
agents_networks
(num_agents=100)		 3.18 0.44
agents_networks
(num_agents=500)		 37.28 1.16
geo_schelling
(default parameters)		 0.79 0.62
geo_schelling (points & polygons)
(default parameters)		 1.49 1.19
geo_sir
(default parameters)		 0.13 0.13
population
(default parameters)		 12.88 10.31

@wang-boyu wang-boyu added this to the v0.7.0 milestone Dec 24, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 24, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9dfbe7c) 75.90% compared to head (205f850) 78.14%.

Files Patch % Lines
mesa_geo/geospace.py 84.61% 3 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
+ Coverage   75.90%   78.14%   +2.23%     
==========================================
  Files          10       10              
  Lines         660      691      +31     
  Branches      138      151      +13     
==========================================
+ Hits          501      540      +39     
+ Misses        139      127      -12     
- Partials       20       24       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wang-boyu wang-boyu force-pushed the agentlayer/spatial-index branch 3 times, most recently from 36cce84 to e961994 Compare December 27, 2023 06:24
@wang-boyu wang-boyu force-pushed the agentlayer/spatial-index branch from e961994 to 205f850 Compare December 27, 2023 06:25
@wang-boyu wang-boyu marked this pull request as ready for review December 27, 2023 06:30
@wang-boyu
Copy link
Copy Markdown
Member Author

wang-boyu commented Dec 27, 2023

@Corvince @rht would you like to help review this PR? Thanks : )

@Corvince
Copy link
Copy Markdown
Contributor

Corvince commented Dec 27, 2023

Hi, yes, I can do that hopefully tonight or tomorrow!

@Corvince
Copy link
Copy Markdown
Contributor

Corvince commented Dec 29, 2023

Sorry I got some visitors, so it will take me some more days until I have a free evening

@wang-boyu
Copy link
Copy Markdown
Member Author

wang-boyu commented Dec 30, 2023

No worries! Enjoy your holidays.

@Corvince Corvince merged commit f9f7d6a into mesa:main Jan 4, 2024
@Corvince
Copy link
Copy Markdown
Contributor

Corvince commented Jan 4, 2024

Finally reviewed and merged :)

Good job

@wang-boyu wang-boyu deleted the agentlayer/spatial-index branch January 5, 2024 00:13
@wang-boyu
Copy link
Copy Markdown
Member Author

wang-boyu commented Jan 5, 2024

Thanks for reviewing! Appreciate it.

@wang-boyu wang-boyu added the enhancement Release notes label label Jan 16, 2024
@wang-boyu wang-boyu mentioned this pull request Jan 18, 2024
Merged
@wang-boyu wang-boyu mentioned this pull request Apr 24, 2024
Closed
@wang-boyu wang-boyu mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Corvince Corvince Corvince approved these changes

Assignees

No one assigned

Labels

enhancement Release notes label

Projects

None yet

Milestone

v0.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wang-boyu @Corvince