solara: Add virus_on_network network example#56
Conversation
rht
force-pushed
the
network
branch
2 times, most recently
from
9592ab8 to
67bfde6
Compare
rht
changed the title
|
This is ready to merge. |
Corvince
left a comment
Corvince
left a comment
There was a problem hiding this comment.
You need to change from viz to model, otherwise just some minor suggestions.
|
|
||
| width = [] # edge width | ||
| edge_color = [] | ||
| for u, v in graph.edges(): |
There was a problem hiding this comment.
u, v, w and ec are quite not-descriptive. Maybe call it edge_width, edge_color here and above edge_colorss and edge_widths ?
There was a problem hiding this comment.
edge_color in NetworkX is a list of edge colors. As much as this is confusing, I have to stay consistent with NetworkX. Ditto with the plural for edge_width.
u, v should be fine for undirected graph, just like i, j for 2D grid.
There was a problem hiding this comment.
See edge_color in https://networkx.org/documentation/stable/reference/generated/networkx.drawing.nx_pylab.draw_networkx.html, which may be a scalar or vector.
Fixed. |
2 participants
Waiting until mesa/mesa#1767 is merged and we have a release.