Skip to content

Epstein civil violence: Switch to experimental datacollector#158

Closed
rht wants to merge 2 commits intomesa:mainfrom
rht:epstein_experimental
Closed

Epstein civil violence: Switch to experimental datacollector#158
rht wants to merge 2 commits intomesa:mainfrom
rht:epstein_experimental

Conversation

@rht
Copy link
Copy Markdown
Contributor

@rht rht commented Aug 13, 2024

No description provided.

"Cops": self.count_cops,
}
agent_reporters = {
"x": lambda agents: [pos[0] for pos in agents.get("pos")],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is awkward. It is better to use instead lambda a: a.pos[0]. But this means AgentSet needs to have the feature of .apply() along the line of DataFrame's apply.

This also means that the new DataCollector heavily relies on AgentSet in order to remain simple. Simple is good.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @quaquel was also thinking in this direction: mesa/mesa#1944 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am back in office and do have some time. However, I lot has been happening wrt to MESA so @EwoutH if you have 30 minutes to bring me up to speed, I am happy to take a look at the apply idea.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to hear! Let me get back to you what works.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quaquel would tomorrow early afternoon work?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, just email me a time and place (online or my office)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants