Remove ContinuousSpaceAgent.pos property (Fixes #3399)#3528
Merged
Remove ContinuousSpaceAgent.pos property (Fixes #3399)#3528
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
ContinuousSpaceAgent.posproperty.Maintainer feedback in issue #3399 requested that
agent.posbe fully removed rather than kept as an alias toposition.This change deletes the
posproperty and its setter fromcontinuous_space_agents.py, keepingpositionas the single source of truth for agent positions.closes #3399.