fix: allow FixedAgent removal via public cell setter#3467
Closed
fix: allow FixedAgent removal via public cell setter#3467
Conversation
b0fbc03 to
0012341
Compare
07b1708 to
95448d4
Compare
|
Performance benchmarks:
|
Member
|
We have discussed this issue in detail. I remain unconvinced by the need for this so I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Closes: #3466
The cleanup logic was moved out of the
remove()method and into the cell property descriptor, where it properly belongs.Previously,
FixedAgent.remove()had to bypass the publiccellAPI and modify private state directly. This created fragile behavior and inconsistent removal logic.With this fix:
FixedAgentno longer needs to manually modify private attributes.Without this change, any attempt to manually clear a
FixedAgent’s cell outside of theremove()method would still triggerValueErrorcrashes.