Skip to content

Add type hints to internal generator in AgentSet.select#3410

Merged
quaquel merged 2 commits intomesa:mainfrom
Tushar1733:main
Mar 2, 2026
Merged

Add type hints to internal generator in AgentSet.select#3410
quaquel merged 2 commits intomesa:mainfrom
Tushar1733:main

Conversation

@Tushar1733
Copy link
Copy Markdown
Contributor

@Tushar1733 Tushar1733 commented Mar 2, 2026

This PR adds explicit type hints to the internal agent_generator function in AbstractAgentSet.select.
No functional changes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 2, 2026

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔴 +6.5% [+5.5%, +7.4%] 🔵 +0.8% [+0.5%, +1.1%]
BoltzmannWealth large 🔵 +3.6% [+2.0%, +5.1%] 🔵 +5.2% [-0.6%, +12.0%]
Schelling small 🔴 +5.8% [+5.1%, +6.5%] 🔵 +3.4% [+2.8%, +4.1%]
Schelling large 🔵 +1.1% [+0.4%, +1.7%] 🔴 +9.2% [+3.5%, +14.4%]
WolfSheep small 🔵 +3.3% [+2.6%, +4.0%] 🔵 +2.3% [+1.7%, +2.9%]
WolfSheep large 🔵 -1.9% [-3.4%, -0.5%] 🟢 -5.5% [-7.6%, -3.4%]
BoidFlockers small 🔵 -0.1% [-0.6%, +0.3%] 🔵 -1.5% [-1.7%, -1.2%]
BoidFlockers large 🔵 +0.8% [+0.2%, +1.4%] 🔵 -2.6% [-3.0%, -2.1%]

@quaquel quaquel added the enhancement Release notes label label Mar 2, 2026
@quaquel quaquel merged commit dfc6b8c into mesa:main Mar 2, 2026
11 of 13 checks passed
EwoutH pushed a commit that referenced this pull request Mar 15, 2026
@Tushar1733 @quaquel @EwoutH
Add type hints to internal generator in AgentSet.select (#3410)
58d0577 
Co-authored-by: Jan Kwakkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quaquel quaquel quaquel approved these changes

Assignees

No one assigned

Labels

enhancement Release notes label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tushar1733 @quaquel