Add time column to empty dataframe in datarecorder#3408
Merged
Conversation
|
Performance benchmarks:
|
quaquel
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency in
get_table_dataframewhere empty datasets would bypass their specific reconstruction logic if storage.blocks is empty( for eg when you call recorder.clear()). Because Datasets do not storetimein their metadata, this premature short-circuit caused their empty DataFrame outputs to be missing thetimecolumn entirely.Changes:
storage.blocks.data_type == unknown).Previously if you run
Old output
Note: Here
timeis in columns because modeldataset stores data as a dictionary( for eg. {"gini":.., "time":..) but this behavior would be changed once #3389 is mergedNew Output
If you run above setup with start_time > 5( i.e data_type=="unknown") then output would be
Old output
New Output