Convert DiscreteSpace to an Abstract Base Class#3387
Merged
Conversation
codebreaker32
force-pushed
the
make_discrete_space_abc
branch
from
a68b563 to
c3b6adb
Compare
|
Performance benchmarks:
|
codebreaker32
force-pushed
the
make_discrete_space_abc
branch
from
c3b6adb to
49f1ac3
Compare
codebreaker32
force-pushed
the
make_discrete_space_abc
branch
from
a6a2145 to
bb0ecc1
Compare
quaquel
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Converts
DiscreteSpaceinto a formal Abstract Base Class (abc.ABC) to enforce a strict spatial API contract across all environments. Subclasses are now mandated to implement fundamental spatial hooks likefind_nearest_celland_connect_cells.Implementation
mesa/discrete_space/discrete_space.py: InheritedDiscreteSpacefromabc.ABCand applied@abstractmethoddecorators tofind_nearest_celland_connect_cells.mesa/discrete_space/grid.py: RaiseNotImplementedErrorin_connect_cells_2dand_connect_cells_ndAdditional Notes
This PR paves the way for the continuous-to-discrete synchronization layer required by Stacked Spaces. See #3268 and #2585 (reply in thread) for discussions