Fix inconsistent state when assigning CellAgent to full cell#3374
Merged
Fix inconsistent state when assigning CellAgent to full cell#3374
Conversation
quaquel
approved these changes
Feb 24, 2026
|
Performance benchmarks:
|
EwoutH
pushed a commit
that referenced
this pull request
Mar 15, 2026
* Fix inconsistent state when assigning CellAgent to full cell * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jan Kwakkel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents inconsistent state when assigning a
CellAgentto a cell that is already at capacity. Previously, a failed assignment could leave the agent pointing to a cell that did not actually contain it.Fixes #3373
Implementation
The setter logic for
CellAgent.cellwas reordered to ensure state is only mutated after successful placement.The new behavior attempts to add the agent to the new cell first. Only if that succeeds, the agent from the old cell (if any) is removed and the agent's internal _cell reference is updated.
Testing
Added a minimal reproduction case that fills a cell, attempts to assign another agent and verifies whether an exception is raised., if
agent.cellremains unchanged and if the agent is not present incell.agents.