Fix: Pin starlette<1.0 to unblock CI / solara tests#3370
Merged
Conversation
quaquel
reviewed
Mar 2, 2026
Co-authored-by: Jan Kwakkel <[email protected]>
quaquel
approved these changes
Mar 2, 2026
Member
|
Sorry, should have commented here. But: The pin should be |
EwoutH
changed the title
Merged
EwoutH
pushed a commit
that referenced
this pull request
Mar 15, 2026
See widgetti/solara#1143 Co-Authored-By: Jan Kwakkel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins
starlette<0.45.0in the project dependencies to resolve a breaking CI failure caused by the latest Starlette release.Bug / Issue
Closes #3369
Starlette 0.45.0 entirely removed the deprecated
on_startupparameter.solaracurrently relies on this parameter during server initialization, causing an immediateTypeErrorthat crashes thepytesttest collection step.Implementation
starlette<0.45.0topyproject.tomloptional dependencies. This is a temporary constraint to unblock Mesa's CI untilsolaraupdates its framework to use the modernlifespancontext manager protocol.Testing
pytest tests/locally to ensure the test suite successfully initializes and runs without the Starlette initialization error.