Enforce default physical layout for Network spaces#3355
Merged
Conversation
|
Performance benchmarks:
|
codebreaker32
changed the title
nx.circular_layout
quaquel
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the
Networkspace to ensure thatCell._positionis never None for networks, moving the responsibility of position generation out of the visualization layer and into the model layerMotivation:
Previously, initializing a purely topological network (
layout=None) resulted in empty cell positions. This forced the visualization backends to manually calculate fallback layouts (likespring_layout), leading to brittle rendering logic and misaligned bounding boxes. As discussed in #3345, enforcing a default layout at the model level solves this.nx.circular_layoutwas chosen as the default because it is cheaper for extremely large networks as well.Key Changes:
Network.__init__to usenx.circular_layoutas the default layout argument.layout=None.This change paves the way for #3345 to directly use Cell.position for visualization tasks.