Add tests for execution ordering and cancellation invariants for EventList#3353
Merged
Add tests for execution ordering and cancellation invariants for EventList#3353
Conversation
|
Performance benchmarks:
|
quaquel
reviewed
Feb 22, 2026
tests/time/test_events.py
Outdated
|
|
||
|
|
||
| def test_eventlist_fifo_same_time_same_priority_execution(): | ||
| """Events with identical time and priority execute in insertion order.""" |
Member
There was a problem hiding this comment.
that's not true, they execute on event id order
Contributor
Author
There was a problem hiding this comment.
I'll change the function name and docstring to reflect that, thanks.
souro26
force-pushed
the
test-eventlist-invariants
branch
from
8c031b0 to
6d2f408
Compare
quaquel
approved these changes
Feb 23, 2026
EwoutH
pushed a commit
that referenced
this pull request
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds explicit tests covering
EventListexecution semantics:These tests document and protect behavior already relied upon by the event engine