Optimize Event.__lt__ to avoid tuple allocation#3336
Merged
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Performance benchmarks:
|
quaquel
approved these changes
Feb 17, 2026
Krishsharma179
pushed a commit
to Krishsharma179/mesa
that referenced
this pull request
Feb 21, 2026
* Optimize Event.__lt__ to avoid tuple allocation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
EwoutH
pushed a commit
that referenced
this pull request
Mar 15, 2026
* Optimize Event.__lt__ to avoid tuple allocation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the tuple-based comparison in
Event.__lt__with direct attribute comparisons to avoid temporary tuple allocation during heap operations. Ordering semantics remains the same (time, priority, unique_id).Fixes #3333
Motive
Event.__lt__is called frequently byheapqduring event scheduling. The previous implementation constructed temporary tuples on every comparison In heavy scheduling workloads, this leads to repeated small allocations and unnecessary overhead. Avoiding tuple creation reduces comparison cost while preserving the exact same ordering semantics.Implementation
The tuple comparison
was replaced with direct sequential comparison:
No changes were made to event semantics, scheduling logic, or public APIs.
Additional Notes
mesa.timetests pass.