Fix Schedule validation for start > end#3326
Merged
Conversation
souro26
force-pushed
the
schedule-validation-check-fix
branch
from
8608874 to
5f1bef7
Compare
|
Performance benchmarks:
|
quaquel
approved these changes
Feb 16, 2026
quaquel
added
enhancement
Krishsharma179
pushed a commit
to Krishsharma179/mesa
that referenced
this pull request
Feb 21, 2026
* Fix Schedule validation for start > end * ruff issues * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jan Kwakkel <[email protected]>
EwoutH
pushed a commit
that referenced
this pull request
Mar 15, 2026
* Fix Schedule validation for start > end * ruff issues * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jan Kwakkel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fix ensures that the
Scheduleclass correctly validates when the start time is after the end time, raising aValueErrorto prevent an invalid scheduling window. It addresses the issue where models could be misconfigured with an invalid schedule, leading to unexpected behavior.Fixes #3321
Bug / Issue
The
Scheduleclass currently allows a start time that is later than the end time, which creates an invalid execution window. This behavior is inconsistent with the purpose of defining valid execution intervals for models and can lead to models running in a broken state.Implementation
__post_init__to ensure that if both start and end are set, start must not be greater than end.ValueErroris raised when the invalid configuration is detected, preventing the model from running with an invalid schedule.Testing
Added a test case in
test_schedule_run.pyto check that theScheduleraises aValueErrorwhen start > end.Additional Notes
This fix ensures better configuration and prevents mistakes that could cause models to fail without warning.