Conversation
EwoutH
reviewed
Feb 16, 2026
EwoutH
reviewed
Feb 16, 2026
EwoutH
approved these changes
Feb 16, 2026
Member
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Pre-approving, thanks for this and updating the tutorials.
We have to decide what we want to do with the user examples in mesa-examples. I think simple/low hanging fruit should be picked, but we might not want to update all as we remove/replace more complex stuff. We can also keep an tracking issue open and engage the community to help us.
Ideally we have some sort of guidelines for that so we don't have this discussion every PR that breaks examples in mesa-examples.
Member
|
I wrote something up on how to handle this. |
Member
Author
|
I opened a pr on mesa-examples for fixing this. I am merging this PP in the meantime. |
Krishsharma179
pushed a commit
to Krishsharma179/mesa
that referenced
this pull request
Feb 21, 2026
* remove seed kwarg * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * improve docstring * update tutorials to use rng instead of seed * Update 4_adding_space.ipynb * 3 more tutorials --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seed was deprecated in Mesa 3. This PR removes it as an argument to
model.Model(), cleans up the inner workings ofmodel.Modelrelated toseed, and modifiesreset_rngto also resetmodel.random. Last, it updates all tutorials to userng.Note
I focused on just removing the deprecated seed argument. There is still a need for a separate decision on whether to keep rng as a separate argument or force users to always use Scenario or a Scenario subclass.