Merged
Conversation
|
Performance benchmarks:
|
quaquel
added
the
trigger-benchmarks
|
Performance benchmarks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small maintenance PR that cleans up the docstrings and tests for mesa_signals. Nothing API wise is changed, just cleaning up stale code, fixing outdated docstrings, and some small fixes to tests.
Code-wise, the only change is that Observable now emits a signal after changing the attribute instead of before. This is the correct behavior, for otherwise if the signal indirectly triggers a get on the observable it still returns the old value instead of the new value.