fix: preserve falsy evaluation values in find_combinations#3237
Merged
fix: preserve falsy evaluation values in find_combinations#3237
Conversation
|
Performance benchmarks:
|
quaquel
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a logic error in
find_combinationswhere valid evaluation results were silently discarded when their value was falsy (e.g.0.0). As a result, combinations with legitimate zero-valued scores were incorrectly excluded from the output.Bug / Issue
evaluation_funcis typed to return a float, andevaluate_combinationreturns (candidate_group,value) when evaluation succeeds.However,
find_combinationspreviously filtered results using a truthiness check (if result:), which caused valid falsy values such as0.0to be dropped unintentionally.This behavior is inconsistent with the function’s type contract and makes it impossible for users to represent neutral or zero-utility combinations.
Implementation
Replaced the truthiness check with an explicit
is not Nonecheck to distinguish between “no evaluation result” and valid falsy valuesRenamed a local variable for clarity to reflect that the group is a tuple rather than a set
The change is behavior-preserving for all non-falsy values and only affects cases that were previously handled incorrectly.
Testing
Added a regression test that verifies combinations with zero-valued evaluation results are preserved
All existing
meta_agentstests pass