Fix pickling for scheduled events by serializing weak-referenced callbacks safely#3205
Merged
Fix pickling for scheduled events by serializing weak-referenced callbacks safely#3205
Conversation
|
Performance benchmarks:
|
EwoutH
force-pushed
the
simulation_event_pickling
branch
from
ea7fd49 to
b0378a6
Compare
Member
Author
|
@quaquel rebased and added tests. |
quaquel
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cherry-pick from #3204, to keep that PR atomic.
This PR adds
__getstate__/__setstate__to the event object inmesa.experimental.devs.eventlistto make it pickle-friendly when the callback is stored as a weak reference. During pickling we materialize the weak reference into a temporary strong reference (_fn_strong) and omit the weakref itself, and during unpickling we restore the callback by recreating the appropriate weak reference (WeakMethodfor bound methods,reffor functions) or leaving it asNonewhen absent.