Merged
Conversation
quaquel
added
example
|
Performance benchmarks:
|
tpike3
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the shapley value calculation in the alliance formation model.
The old implementation heavily relies on indexing on an agent set, which is painfully slow. In a benchmark on all example models, for 100 steps each, this one method was responsible for 15% of the total runtime, simply due to indexing on agentsets (i.e.,
model.agents[5]) being so slow.This PR avoids the problem by destructing the list into the two agents and using these in all places were indexing was used.
I'll raise a separate issue about
AgentSet.__getitem__later.