Resolve FIXME in sugarscape_g1mt/agents.py#3062
Merged
Conversation
|
Performance benchmarks:
|
quaquel
reviewed
Jan 4, 2026
Contributor
Author
|
Should I rebase my pr or can be merged as it is? |
quaquel
approved these changes
Jan 5, 2026
Contributor
Author
|
Big thanks @quaquel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors a small portion of the
movemethod in theSugarscapeexample'sagentto be more efficient.Bug / Issue
The existing code used two separate steps to identify the best cells for an
agentto move to, which was slightly inefficient. The expectation was to refactor this into a more concise, single operation.Implementation
The code was refactored to use a single list comprehension with
enumerate.Testing
I have tested it locally, all the tests pass.
Summary of the particular tests which are related:
Additional Notes
This is a minor refactoring that improves code quality. No functional changes are intended or expected.