Minor Refactoring in solara_viz#3059
Merged
Sahil-Chhoker merged 6 commits intomesa:mainfrom Jan 9, 2026
Merged
Conversation
|
Performance benchmarks:
|
Sahil-Chhoker
approved these changes
Jan 9, 2026
Collaborator
There was a problem hiding this comment.
LGTM!, But this is not what I meant by managing dependencies properly, just keep that line as it is @codebreaker32.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR handles the dependences elegantly in
SpaceRendererComponentby extending the newer dependencies to the required ones.The Issue
Previously, the component used
dependencies.append(...)directly on the list passed from the parent. In reactive frameworks like Solara (and React), input props should be treated as read-only. Modifying them causes side effects where the parent's local state is unexpectedly altered by the child component. This can lead to hard-to-debug issues where dependency lists grow indefinitely or contain stale data across re-renders in the parent scope.The Fix
I have replaced the in-place mutation with a safe concatenation strategy. The component now creates a new, transient list for the current render cycle, leaving the parent's data untouched.
Before:
After:
Updated by @Sahil-Chhoker to match the PR functionality.