Add initialization check in Simulator.run_for()#3036
Merged
Conversation
df9567b to
f868b84
Compare
|
Performance benchmarks:
|
quaquel
reviewed
Dec 30, 2025
Collaborator
Author
|
Made the changes @quaquel |
Member
|
Can you update tests/experimental/test_devs.py with appropriate tests that cover both the bug and the updated behavior? Once those tests are in, this seems good to go. |
|
Performance benchmarks:
|
8d4e284 to
42fb97b
Compare
Collaborator
Author
|
I have added the required tests also |
quaquel
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implemented a mandatory initialization check in
Simulator.run_for()to explicitly validate that the simulator has been set up before execution.Motive
The
run_formethod previously contained a #fixme comment noting the need for an initialization check. Without this check, attempting to run the simulator without a model lead to errorImplementation
Replaced the placeholder comment with a conditional check.
Usage Examples
This change ensures that improper usage is caught immediately: