test: Replace deprecated iterations with rng in batch_run tests#2984
Merged
test: Replace deprecated iterations with rng in batch_run tests#2984
iterations with rng in batch_run tests#2984Conversation
Fixes deprecation warnings by updating test calls to use the new `rng` parameter instead of the deprecated `iterations` parameter. Adds a test to verify the deprecation warning is raised correctly. - Replace `iterations=1` with `rng=[None]` - Replace `iterations=6` with `rng=[None] * 6` - Replace `iterations=2` with `rng=[None, None]` - Add test for deprecation warning
quaquel
approved these changes
Dec 22, 2025
|
Performance benchmarks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
test_batch_run.pyto eliminate deprecation warnings by replacing the deprecatediterationsparameter with the newrngparameter.Changes
rnginstead ofiterations:test_batch_run:iterations=1→rng=[None]test_batch_run_single_core:iterations=6→rng=[None] * 6test_batch_run_unhashable_param:iterations=2→rng=[None, None]test_iterations_deprecation_warningto verify the deprecation warning is raised when usingiterationsTesting
All existing tests pass without deprecation warnings. The new test confirms that using
iterationsstill works but raises the appropriateDeprecationWarningFollow-up on #2841.