Conversation
Deleted Dockerfile, docker-compose.yml, flake.nix, flake.lock, uv.lock, and binder/environment.yml to remove containerization and environment management via Docker, Nix, and Binder. Also removed mypy.ini and a maintenance script, and refactored test_lifespan.py to rename 'inactivate' to 'deactivate' for consistency.
Removed .codespellignore and .coveragerc files and migrated their configurations into pyproject.toml. Updated pre-commit config to remove reference to .codespellignore, consolidating project configuration.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
I like the PR, will wait for others, in particular @tpike3, to check if there is anything they use. But I am fine with merging this. |
|
This is awesome @EwoutH thanks! We do need the binder/environment.yaml that is for the tutorials. We can't switch to pure colab, because colab and solara do not play well together. Although I did ping google to add solara support, cause why not. |
|
Can you explain how it is used exactly? Maybe it can be integrated in the |
Binder uses |
|
Would defining another optional dependency work? Lines 47 to 55 in 9c67a63 |
|
Okay we can't remove this yet, see: I will restore it. Any other comments on this PR? |
Move to pyproject.toml when upstream implemented in jupyterhub/repo2docker#1427
|
Restored |
3 participants
Summary
This PR is an end-of-year repository cleanup focused on reducing maintenance overhead and consolidating project configuration. Removes over 3000 lines of unused code and configurations.
Key changes include the removal of containerization and alternative environment files (Docker, Nix, Binder), the deletion of obsolete maintenance scripts, and the migration of tool configurations into
pyproject.toml.Inspired by this Dutch hit duo.
Motive
It doesn't spark me joy.
If you want to really really keep anything, please say so (and motivate).
Removed Items
Dockerfileanddocker-compose.ymlto drop containerization support.flake.nixandflake.lockto remove Nix-based environment management.Binder: RemovedKeep until repo2docker#1427 is implementedbinder/environment.ymlto discontinue Binder interactive environment support.uv.lockto decomplicate dependency handling..codespellignore,.coveragerc, andmypy.iniby consolidating settings intopyproject.toml.fetch_unlabeled_prs.pyas it is no longer in use. Replacement.Before (left) and after (right)