Conversation
|
Performance benchmarks:
|
Contributor
Author
|
The doc build failed on |
quaquel
reviewed
Dec 18, 2025
| self.grid = mesa.discrete_space.OrthogonalVonNeumannGrid( | ||
| (width, height), capacity=1, torus=True, random=self.random | ||
| ) | ||
| if grid_type == "Moore": |
Member
There was a problem hiding this comment.
consider changing both this if else statement and the one in step to a match case structure:
match activation_order:
case "Von Neumann":
pass. # your original if code
case "Moore"
pass #your original else code
case _:
raise ValueError("unknown value of activation_order")This ensures that we get a value error if an invalid value is passed.
Contributor
Author
There was a problem hiding this comment.
Done. Please review it now.
Member
|
Thanks for this. I have merged main back into your branch which should solve the failing docs. I also have one suggestion. Looks good to me otherwise. |
Member
|
Thanks for the PR! I appreciated the really clean diff and detailed description with screenshots. |
EwoutH
changed the title
EwoutH
approved these changes
Dec 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds interactive selectors to the
EpsteinCivilViolenceexample, allowing users to dynamically choose the Activation Order (Random vs. Sequential) and Grid Type (Moore vs. Von Neumann) directly from the Solara GUI.Motive
In the discussion for PR #2408, maintainer @quaquel noted that the activation order (Random vs. Sequential) significantly impacts model stability and suggested making it a user input. Additionally, it was observed that swapping the grid topology (Moore vs. Von Neumann) drastically changes agent behavior. Exposing these parameters allows users to explore these dynamics easily without modifying the code.
Implementation
model.py: UpdatedEpsteinCivilViolence.__init__to acceptactivation_orderandgrid_typearguments. Added logic to initialize the corresponding Grid class (OrthogonalMooreGridorOrthogonalVonNeumannGrid) and handle the scheduling logic in thestep()method.app.py: Addedactivation_orderandgrid_typetomodel_paramsasSelectwidgets, enabling the dropdown menus in the Solara sidebar.model.py: Updated docstrings to reflect the new parameters.Usage Examples
Before:
After:
Run the example:
In the sidebar, use the Activation Order dropdown to switch between "Random" and "Sequential".
Use the Grid Type dropdown to switch between "Moore" (8 neighbors) and "Von Neumann" (4 neighbors).
Additional Notes
Defaults are set to Von Neumann and Random to match the behavior established in recent updates.
"Sequential" activation relies on
self.agents.do("step"), while "Random" usesself.agents.shuffle_do("step").